Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cache original_nodes with nodes #10722

Merged
merged 3 commits into from
Jan 3, 2024
Merged

fix: cache original_nodes with nodes #10722

merged 3 commits into from
Jan 3, 2024

Conversation

sheharyaar
Copy link
Contributor

Description

upstream original_nodes is not updated when fill_node_info structure after cloning the nodes table. This PR stores the cloned nodes in the original nodes before fill_node_info

Fixes # (issue)

#9805

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@shreemaan-abhishek
Copy link
Contributor

@ZhangShangyu could you please review?

shreemaan-abhishek
shreemaan-abhishek previously approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@shreemaan-abhishek shreemaan-abhishek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@sheharyaar sheharyaar changed the title fix: clone new_nodes to original_nodes before fill_node_info fix: save original_nodes to cache along with nodes Dec 29, 2023
@sheharyaar
Copy link
Contributor Author

@monkeyDluffy6017 , I have made some changes to the PR, please review this.

@sheharyaar sheharyaar changed the title fix: save original_nodes to cache along with nodes fix: remove original_nodes Jan 2, 2024
@sheharyaar sheharyaar changed the title fix: remove original_nodes fix: cache original_nodes with nodes Jan 3, 2024
sheharyaar and others added 3 commits January 3, 2024 12:17
@sheharyaar
cache original_nodes with nodes
eb0d256 
Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>
@monkeyDluffy6017 @sheharyaar
fix: minor tweaks
a594ef9
@sheharyaar
fix: minor tweaks
ba846a1 
Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>
@monkeyDluffy6017 monkeyDluffy6017 merged commit 55f8a20 into apache:master Jan 3, 2024
41 checks passed
@monkeyDluffy6017 monkeyDluffy6017 mentioned this pull request Jan 3, 2024
Closed
5 tasks
@sheharyaar sheharyaar mentioned this pull request Jan 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monkeyDluffy6017 monkeyDluffy6017 monkeyDluffy6017 approved these changes

@shreemaan-abhishek shreemaan-abhishek shreemaan-abhishek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sheharyaar @shreemaan-abhishek @monkeyDluffy6017