Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add schema attribute definition for some log plug-ins #10738

Merged

Conversation

smileby
Copy link
Contributor

@smileby smileby commented Dec 31, 2023

Description

fixed #9190

Add schema attribute definition for some log plug-ins.

schema attribute details as follows
Add include_req_body and include_req_body_expr attributes to file-logger
Add include_req_body_expr attributes to http-logger
Add include_req_body_expr attributes to loggly
Add include_resp_body_expr and include_resp_body_expr attributes to tencent-cloud-cls

Fixes # (issue)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@smileby
Copy link
Contributor Author

smileby commented Jan 2, 2024

Please advise on how to resolve the following issue.

[ info ] stop -> [ Start ]
/home/runner/work/apisix/apisix/bin/apisix stop
/usr/local/openresty//luajit/bin/luajit ./apisix/cli/apisix.lua stop
Error: nginx: [error] open() "/home/runner/work/apisix/apisix/logs/nginx.pid" failed (2: No such file or directory)
[ info ] stop -> [ Done ]
+ git checkout conf/config.yaml
Updated 0 paths from the index
Error: Process completed with exit code 1.

@monkeyDluffy6017
Copy link
Contributor

It doesn't matter, the ci CLI Test fails occasionaly, we will fix it later

@monkeyDluffy6017 monkeyDluffy6017 merged commit 2f6fd50 into apache:master Jan 3, 2024
44 checks passed
@smileby smileby deleted the feat-add_attr_for_schema_definition branch January 3, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: attributes undocumented for certain logging plugins
3 participants