fix(cors): all origins could pass when allow_origins_by_metadata is set #10948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theweakgod
changed the title
|
Let's discuss in the issue |
👌 |
monkeyDluffy6017
approved these changes
Feb 23, 2024
shreemaan-abhishek
approved these changes
Feb 23, 2024
Neilblaze
approved these changes
Feb 25, 2024
|
Tested it locally, Works as intended, LGTM. |
sheharyaar
approved these changes
Feb 26, 2024
monkeyDluffy6017
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10946
Resolved the issue where all origins could pass through when allow_origins_by_metadata was set and allow_origins was set to the default value "*".
Checklist