Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: after updating the header, get the old value from the ctx.var #11329

Merged
merged 1 commit into from
Jun 6, 2024
Merged

fix: after updating the header, get the old value from the ctx.var #11329

merged 1 commit into from
Jun 6, 2024

Conversation

AlinsRan
Copy link
Contributor

@AlinsRan AlinsRan commented Jun 5, 2024

Description

Fixes #11325

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@AlinsRan AlinsRan marked this pull request as ready for review June 5, 2024 07:22
@AlinsRan AlinsRan merged commit 953be46 into apache:master Jun 6, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moonming moonming moonming approved these changes

@nic-chen nic-chen nic-chen approved these changes

@shreemaan-abhishek shreemaan-abhishek shreemaan-abhishek approved these changes

@nic-6443 nic-6443 Awaiting requested review from nic-6443

@Revolyssup Revolyssup Awaiting requested review from Revolyssup

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: after using core.request.set_header to set the header, ctx.var still caches the old value
4 participants
@AlinsRan @moonming @nic-chen @shreemaan-abhishek