Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create the health checker in access phase #3240

Merged
merged 1 commit into from
Jan 11, 2021
Merged

fix: create the health checker in access phase #3240

merged 1 commit into from
Jan 11, 2021

Conversation

spacewander
Copy link
Member

Allow to call yield function in the healthcheck.

Signed-off-by: spacewander spacewanderlzx@gmail.com
Co-authored-by: YuanSheng Wang membphis@gmail.com

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander spacewander changed the title bugfix: create the health checker in access phase fix: create the health checker in access phase Jan 11, 2021
@spacewander
fix: create the health checker in access phase
2553b65 
Allow to call yield function in the healthcheck.

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Co-authored-by: YuanSheng Wang <membphis@gmail.com>

Fix apache#1851
Fix apache#2842

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review January 11, 2021 13:04
@spacewander spacewander mentioned this pull request Jan 11, 2021
Closed
4 tasks
@spacewander spacewander merged commit fa029d4 into apache:master Jan 11, 2021
@spacewander spacewander deleted the t22 branch January 11, 2021 13:35
sysulq pushed a commit to sysulq/apisix that referenced this pull request Jan 15, 2021
@spacewander @sysulq
fix: create the health checker in access phase (apache#3240)
079dabb 
Allow to call yield function in the healthcheck.

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Co-authored-by: YuanSheng Wang <membphis@gmail.com>

Fix apache#1851
Fix apache#2842
@spacewander spacewander mentioned this pull request Feb 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@membphis membphis membphis approved these changes

@moonming moonming moonming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spacewander @membphis @moonming