-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dns discovery #3629
feat: add dns discovery #3629
Conversation
1b6f00d
to
b3c6ecf
Compare
Fix apache#3517 Signed-off-by: spacewander <spacewanderlzx@gmail.com>
b3c6ecf
to
197f650
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except minor style things
|
||
local new_nodes, err = dis.nodes(up_conf.service_name) | ||
if not new_nodes then | ||
return http_code_upstream_unavailable, "no valid upstream node: " .. (err or "nil") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
http_code_upstream_unavailable
:
For static variables, use capital letters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed my idea and followed your suggestion.
See apache#3629 (comment) Signed-off-by: spacewander <spacewanderlzx@gmail.com>
See apache#3629 (comment) Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Fix #3517
Signed-off-by: spacewander spacewanderlzx@gmail.com
What this PR does / why we need it:
Pre-submission checklist: