Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use the builtin server by default #3907

Merged
merged 1 commit into from
Mar 25, 2021
Merged

fix: use the builtin server by default #3907

merged 1 commit into from
Mar 25, 2021

Conversation

spacewander
Copy link
Member

Fix #3906

Signed-off-by: spacewander spacewanderlzx@gmail.com

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander
fix: use the builtin server by default
ede6b0e 
Fix apache#3906

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review March 25, 2021 07:25
@hackeryutu
Copy link

Merging is blocked！！！

@juzhiyuan
Copy link
Member

@hackeryutu just be patient for others to review 😄

@membphis membphis merged commit 83ab543 into apache:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@membphis membphis membphis approved these changes

@tokers tokers tokers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why do I limit the server_name value, but still go to the snippet server block
5 participants
@spacewander @hackeryutu @juzhiyuan @membphis @tokers