feat: add `file-logger` plugin #5831

guoqqqi · 2021-12-16T10:25:06Z

What this PR does / why we need it:

add file-logger plugin

Related: Discuss on the mailing list

Pre-submission checklist:

Did you explain what problem does this PR solve? Or what new features have been added?
Have you added corresponding test cases?
Have you modified the corresponding document?
Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

juzhiyuan · 2021-12-16T11:58:15Z

Hi, maybe you'd better add a TODO checklist in this PR's description 🤔

guoqqqi · 2021-12-20T01:40:45Z

TODO:

add control API
test
docs

Wait for the review to be completed and add the English document

juzhiyuan · 2021-12-30T01:04:00Z

docs/zh/latest/plugins/file-logger.md

+            "file-logger": {
+                "path": "logs/file.log",
+                "custom_fields_by_lua": {"route_id": "return nil"}
+            }


Hi, could we use 2 spaces here?

spacewander · 2021-12-30T01:15:41Z

apisix/plugins/file-logger.lua

+local plugin       =   require("apisix.plugin")
+local ffi          =   require("ffi")
+local bit          =   require("bit")
+


Please don't use a blank line between localized functions.

spacewander · 2021-12-30T01:16:23Z

apisix/plugins/file-logger.lua

+local io_open      =   io.open
+
+local plugin_name  =   "file-logger"
+local O_CREAT      =   00000040 -- create and open


Why not use Lua's std file library? That one is much simpler. See https://www.tutorialspoint.com/lua/lua_file_io.htm

The reason for using ffi to call write is that I do not want to use the cached io.write. For more information on this, see the:

https://m.yisu.com/zixun/194893.html

https://github.com/Kong/kong/blob/master/kong/plugins/file-log/handler.lua

To bypass the user-space cache, there is already a flush method for it.

file:flush()

Hi, @spacewander I am trying to use io.write and file:flush to write logs, but I find that io.open returns a userdata and my attempts to store and read it fail, how do I go about it?

The error msg indicates that you can't log a userdata.

spacewander · 2021-12-30T01:17:24Z

apisix/plugins/file-logger.lua

+    properties = {
+        path = {
+            type = "string",
+            require = true,


This is not a valid JSON schema syntax. Please take a look at https://github.com/apache/apisix/blob/master/apisix/schema_def.lua

spacewander · 2021-12-30T01:20:12Z

apisix/plugins/file-logger.lua

+
+
+function _M.body_filter(conf, ctx)
+    log_util.collect_body(conf, ctx)


Since the first version of file-logger doesn't support logging response body, we don't need to collect it.

spacewander · 2021-12-30T01:21:00Z

apisix/plugins/file-logger.lua

+        entry = log_util.get_full_log(ngx, conf)
+    end
+
+    if conf.custom_fields_by_lua


Look like we don't need to provide custom_fields_by_lua, as we already have "log_util.get_custom_format_log".

spacewander · 2021-12-30T01:27:42Z

apisix/plugins/file-logger.lua

+local pairs        =   pairs
+local load_string  =   loadstring
+local io_open      =   io.open
+


Better to use two blank lines after localized functions.

spacewander · 2021-12-30T01:40:08Z

apisix/plugins/file-logger.lua

+    return {
+        {
+            methods = {"GET"},
+            uris = {"/plugin/file-logger/reopen"},


Suggested change

uris = {"/plugin/file-logger/reopen"},

uris = {"/v1/plugin/file-logger/reopen"},

would be better

spacewander · 2021-12-30T02:06:09Z

apisix/plugins/file-logger.lua

+function _M.control_api()
+    return {
+        {
+            methods = {"GET"},


What about using PUT?
We already use it in the reload: https://github.com/apache/apisix/blob/master/docs/en/latest/architecture-design/plugin.md#hot-reload

spacewander · 2021-12-30T02:07:14Z

apisix/plugins/file-logger.lua

+    schema = schema,
+    metadata_schema = metadata_schema
+}
+


Please use two blank lines to separate each section (localized functions, define module-level variables, define functions, return _M)

spacewander · 2021-12-31T08:42:50Z

apisix/plugins/file-logger.lua

+
+
+local function reopen()
+    local target_pointer, err = io_open('logs/file_pointer', 'r')


There is no need to track the status with a file in disk? We can just iterate all cache fds and reopen them.

We also need to remove the stale cached data when a route used file-logger is deleted. It can be done with a timer:

apisix/apisix/plugins/server-info.lua

Line 240 in cc09ef3

timers.register_timer("plugin#server-info", fn, true)

apisix/apisix/plugins/server-info.lua

Line 248 in cc09ef3

timers.unregister_timer("plugin#server-info", true)

Since only one worker can receive the reopen request, we can use worker event to trigger fd reopen in the other workers, like:

apisix/apisix/discovery/consul_kv/init.lua

Line 376 in cc09ef3

events = require("resty.worker.events")

spacewander · 2021-12-31T08:43:31Z

apisix/plugins/file-logger.lua

+    local target_pointer, err = io_open('logs/file_pointer', 'r')
+    if not target_pointer then
+        core.log.error("failed to open file, error info: " .. err)
+        core.response.exit(400, {error_msg = "failed to open file, error info: " .. err})


Suggested change

core.response.exit(400, {error_msg = "failed to open file, error info: " .. err})

return 400, {error_msg = "failed to open file, error info: " .. err}

spacewander · 2021-12-31T08:44:02Z

apisix/plugins/file-logger.lua

+        reset_pointer:close()
+    end
+
+    core.response.exit(200, 'reopen file-logger successfully')


Better to return a JSON response

guoqqqi · 2022-01-13T08:03:31Z

Hi, can I finish the reopen function in another PR later? I may need to spend some time learning worker.events and timers

spacewander · 2022-01-14T03:05:33Z

It's OK.

spacewander · 2022-01-16T12:33:13Z

apisix/plugins/file-logger.lua

+    properties = {
+        path = {
+            type = "string",
+            match = [[^[^*&%%\`]+$]],


The syntax is still incorrect. See #5831 (comment)

spacewander · 2022-01-16T12:34:33Z

apisix/plugins/file-logger.lua

+    local fd = file_descriptors[conf.path]
+
+    if not fd then
+        local file = io_open(conf.path, 'a+')


Please don't cache fd in this version. We don't have a way to remove it.

spacewander · 2022-01-16T13:27:23Z

apisix/plugins/file-logger.lua

+local io_open      =   io.open
+
+
+local plugin_name  =   "file-logger"


Suggested change

local plugin_name = "file-logger"

local plugin_name = "file-logger"

spacewander · 2022-01-16T13:31:18Z

apisix/plugins/file-logger.lua

+        path = {
+            type = "string",
+            pattern = [[^[^*&%%\`]+$]],
+            err = "not a valid filename"


We don't have err in the jsonschema. BTW, we don't need to verify the path with regex? Different filesystems will have different requirements.

spacewander · 2022-01-16T13:31:50Z

apisix/plugins/file-logger.lua

+    local msg = core.json.encode(log_message) .. "\n"
+
+    if not file then
+        file = io_open(conf.path, 'a+')


Suggested change

file = io_open(conf.path, 'a+')

local file, err = io_open(conf.path, 'a+')

is enough? And remember to check the err.

Oops, I misunderstood here before, I thought this way of writing would cause the file to be reopened on every request

spacewander · 2022-01-16T13:31:57Z

apisix/plugins/file-logger.lua

+        file = io_open(conf.path, 'a+')
+    end
+
+    file:write(msg)


spacewander · 2022-01-16T13:32:34Z

docs/zh/latest/plugins/file-logger.md

+| ---------------- | ------- | ------ | ------------- | ------- | ------------------------------------------------ |
+| log_format       | object  | 可选   | {"host": "$host", "@timestamp": "$time_iso8601", "client_ip": "$remote_addr"} |         | 以 JSON 格式的键值对来声明日志格式。对于值部分，仅支持字符串。如果是以 `$` 开头，则表明是要获取 __APISIX__ 变量或 [Nginx 内置变量](http://nginx.org/en/docs/varindex.html)。特别的，**该设置是全局生效的**，意味着指定 log_format 后，将对所有绑定 file-logger 的 Route 或 Service 生效。 |
+
+**APISIX 变量**


Please update the doc according to the latest http-logger.

spacewander · 2022-01-17T02:29:21Z

apisix/plugins/file-logger.lua

+    local file, err = io_open(conf.path, 'a+')
+
+    if not file then
+        core.log.error("failed to open file: " .. conf.path .. ", error info: " .. err)


Suggested change

core.log.error("failed to open file: " .. conf.path .. ", error info: " .. err)

core.log.error("failed to open file: ", conf.path, ", error info: ", err)

spacewander · 2022-01-17T02:29:42Z

apisix/plugins/file-logger.lua

+    if not file then
+        core.log.error("failed to open file: " .. conf.path .. ", error info: " .. err)
+    else
+        file:write(msg)


Need to handle the err.
And don't forget to close the file

spacewander · 2022-01-17T07:06:26Z

apisix/plugins/file-logger.lua

    else
-        file:write(msg)
-        file:flush()
+        local ok, error = file:write(msg)


Suggested change

local ok, error = file:write(msg)

local ok, err = file:write(msg)

and we need to close the file even failed to write.

BTW, we can use file:write(msg, '\n') to avoid local msg = core.json.encode(log_message) .. "\n"

spacewander · 2022-01-18T01:38:09Z

apisix/plugins/file-logger.lua

        if not ok then
-            core.log.error("failed to write file: ", conf.path, ", error info: ", error)
+            file:close()


We should close the file whether the writing success or not.

spacewander · 2022-01-19T06:42:44Z

docs/en/latest/plugins/file-logger.md

+
+## Name
+
+`file-logger` is a plugin which push a stream of Log data to a specified location. For example, the output path can be customized: `logs/file.log`.


Suggested change

`file-logger` is a plugin which push a stream of Log data to a specified location. For example, the output path can be customized: `logs/file.log`.

`file-logger` is a plugin that pushes a stream of log data to a specified file. For example, the output path can be customized: `logs/file.log`.

spacewander · 2022-01-19T06:44:35Z

apisix/plugins/file-logger.lua

+            core.log.error("failed to write file: ", conf.path, ", error info: ", err)
+        else
+            file:flush()
+            file:close()


We can merge the two close into one

spacewander · 2022-01-19T06:45:02Z

t/plugin/file-logger.t

+                msg = fd:read()
+                fd:close()
+            else
+                fd:close()


spacewander · 2022-01-19T06:45:13Z

t/plugin/file-logger.t

+                fd:close()
+                core.log.error("failed to open file: logs/file.log, error info: ", err)
+            end
+            core.log.warn('msg: ', msg)


Let's check the msg too

Do I need to check all the fields and values in the msg, or do I just need to check a few specific values?

Better to check them all, we can custom the format to avoid timestamps.

spacewander · 2022-01-19T06:46:51Z

t/plugin/file-logger.t

+                 [[{
+                        "plugins": {
+                            "file-logger": {
+                                "path": "file.log"


Let's add a test that the path can't be opened.

spacewander · 2022-01-20T04:45:03Z

t/plugin/file-logger.t

+            ngx.say(body)
+        }
+    }
+--- request


Don't add redundant section

spacewander · 2022-01-20T04:46:51Z

t/plugin/file-logger.t

+                        "client_ip": "$remote_addr"
+                    }
+                }]],
+                [[{


We don't need to check the response, right?

spacewander · 2022-01-20T04:47:07Z

docs/en/latest/plugins/file-logger.md

@@ -84,7 +84,7 @@ You can then find the `file.log` file in the corresponding `logs` directory.
 ### Example

 ```shell
-curl http://127.0.0.1:9080/apisix/admin/plugin_metadata/http-logger -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+curl http://127.0.0.1:9080/apisix/admin/plugin_metadata/file-logger -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '


Please sync to Chinese doc

bisakhmondal · 2022-01-20T07:10:32Z

apisix/plugins/file-logger.lua

+    if not ok then
+        return nil, err
+    end
+    return log_util.check_log_schema(conf)


we don't need this validation as the current file-logger schema doesn't contains any expression like include_resp_body_expr or include_req_body_expr

bisakhmondal · 2022-01-20T07:18:39Z

apisix/plugins/file-logger.lua

+local function write_file_data(conf, log_message)
+    local msg = core.json.encode(log_message)
+    local file, err = io_open(conf.path, 'a+')
+
+    if not file then
+        core.log.error("failed to open file: ", conf.path, ", error info: ", err)
+    else
+        local ok, err = file:write(msg, '\n')
+        if not ok then
+            core.log.error("failed to write file: ", conf.path, ", error info: ", err)
+        else
+            file:flush()
+        end
+        file:close()
+    end
+end


Instead of opening a file handle for each time we dump a log, can we optimize it a bit by keeping the fd open and caching it so that it can be reused (maybe with a timeout, so that it doesn't remain open indefinitely [do we really care about it?])? Because you know, writing something is cheap but opening a file handler for every logs and moving the fd to the EOF takes some resources.
Maybe it's a premature optimization. @spacewander WDYT?

Hi, @bisakhmondal I tried to add a reopen function to it to cache the fd, but I had some problems, so I wanted to finish it later. #5831 (comment)

Okay, @guoqqqi. Thanks.

bisakhmondal · 2022-01-20T07:19:39Z

apisix/plugins/file-logger.lua

+
+
+function _M.log(conf, ctx)
+    local metadata = plugin.plugin_metadata(plugin_name)


How about a gentle info log of the json serialized metadata after this line?

bisakhmondal · 2022-01-20T07:22:37Z

t/plugin/file-logger.t

+=== TEST 1: sanity
+--- config
+    location /t {
+        content_by_lua_block {
+            local plugin = require("apisix.plugins.file-logger")
+            local ok, err = plugin.check_schema({
+                path = "file.log"
+                })
+            if not ok then
+                ngx.say(err)
+            end
+
+            ngx.say("done")
+        }
+    }
+--- response_body
+done
+
+
+
+=== TEST 2: path is missing check
+--- config
+    location /t {
+        content_by_lua_block {
+            local plugin = require("apisix.plugins.file-logger")
+            local ok, err = plugin.check_schema()
+            if not ok then
+                ngx.say(err)
+            end
+
+            ngx.say("done")
+        }
+    }
+--- no_error_log
+property "path" is required


We can go with table-driven checks?

apisix/t/plugin/splunk-hec-logging.t

Lines 46 to 99 in d1d16f4

local configs = {

-- full configuration

{

endpoint = {

uri = "http://127.0.0.1:18088/services/collector",

token = "BD274822-96AA-4DA6-90EC-18940FB2414C",

channel = "FE0ECFAD-13D5-401B-847D-77833BD77131",

timeout = 60

},

max_retry_count = 0,

retry_delay = 1,

buffer_duration = 60,

inactive_timeout = 2,

batch_max_size = 10,

},

-- minimize configuration

{

endpoint = {

uri = "http://127.0.0.1:18088/services/collector",

token = "BD274822-96AA-4DA6-90EC-18940FB2414C",

}

},

-- property "uri" is required

{

endpoint = {

token = "BD274822-96AA-4DA6-90EC-18940FB2414C",

}

},

-- property "token" is required

{

endpoint = {

uri = "http://127.0.0.1:18088/services/collector",

}

},

-- property "uri" validation failed

{

endpoint = {

uri = "127.0.0.1:18088/services/collector",

token = "BD274822-96AA-4DA6-90EC-18940FB2414C",

}

}

}

local plugin = require("apisix.plugins.splunk-hec-logging")

for i = 1, #configs do

ok, err = plugin.check_schema(configs[i])

if err then

ngx.say(err)

else

ngx.say("passed")

end

end

}

}

bisakhmondal · 2022-01-20T07:26:35Z

t/plugin/file-logger.t

+        }
+    }
+--- error_log
+failed to open file: /log/file.log, error info: /log/file.log: No such file or directory


In such a case, how about we try to create a file with the corresponding name. If that returns an error [maybe insufficient permission], we throw it away. Else it would not be a good user experience to create a file each time they create a log configuration. What do you think about it? Thank you

Good idea, as I'm not particularly familiar with it, can I finish it with reopen function later?

Yes sure. Totally up to you. Thanks.

moonming · 2022-01-21T04:12:31Z

conf/config-default.yaml

@@ -375,6 +375,7 @@ plugins:                          # plugin list (sorted by priority)
  - rocketmq-logger                # priority: 402
  - syslog                         # priority: 401
  - udp-logger                     # priority: 400
+  - file-logger                    # priority: 399


The same type of plugin, the first number should be the same. 4xx is for logger plugins

The same type of plugin, the first number should be the same. 4xx is for logger plugins

Ignore this, it looks like it's not the rule anymore

shuaijinchao

support for worker.event and batch queue can be record by opening issues.

bisakhmondal

lgtm

spacewander · 2022-01-21T08:53:32Z

Merged. Thanks!

juzhiyuan · 2022-01-21T10:40:48Z

Hi @guoqqqi, please add this to README refer to @Baoyuantop's PR :)

feat: add file-logger plugin

d110bc4

guoqqqi added 3 commits December 17, 2021 09:50

fix: ci error

eab7273

fix: lint error

afb5258

fix: update code

e40eabc

guoqqqi added 7 commits December 20, 2021 14:19

feat: replace the io.open method

3a1954c

fix: update code

b46ae94

Merge branch 'master' into feat-file-logger-plugin

ccd83a8

fix: update code

2f13213

fix: update code

b96e454

Merge branch 'master' into feat-file-logger-plugin

08bb6ab

docs: add file-logger.md

f368599

guoqqqi marked this pull request as ready for review December 29, 2021 10:01

guoqqqi added 2 commits December 29, 2021 18:07

fix: update docs

faeb2d8

fix: update config.json

ba73e58

juzhiyuan reviewed Dec 30, 2021

View reviewed changes

spacewander reviewed Dec 30, 2021

View reviewed changes

fix: update code

eb62b52

spacewander reviewed Dec 31, 2021

View reviewed changes

fix: remove reopen function

38729d3

fix: chang ffi.C to lua io

f9320bb

spacewander reviewed Jan 16, 2022

View reviewed changes

fix: update code

f22b600

spacewander reviewed Jan 16, 2022

View reviewed changes

guoqqqi added 2 commits January 16, 2022 22:01

fix: add error handling

833ae24

fix: update the zh docs for file-logger

8411f3f

spacewander reviewed Jan 17, 2022

View reviewed changes

guoqqqi added 2 commits January 17, 2022 10:57

fix: add handle the err to the io.write

267ed9f

fix: lint error

9715d31

spacewander reviewed Jan 17, 2022

View reviewed changes

fix: update code

33b53f4

spacewander reviewed Jan 18, 2022

View reviewed changes

guoqqqi added 4 commits January 18, 2022 09:39

fix: update the file:close

eaf0722

test: add test for file-logger

2641a4e

docs: add the docs for en verison

950acfa

test: update the plugin path

6ecf614

spacewander reviewed Jan 19, 2022

View reviewed changes

juzhiyuan requested a review from bisakhmondal January 20, 2022 01:15

fix: update code

fe458d2

spacewander reviewed Jan 20, 2022

View reviewed changes

guoqqqi added 2 commits January 20, 2022 13:07

fix: remove redundant section

8c22d98

test: fix the ci error

6220f1b

bisakhmondal reviewed Jan 20, 2022

View reviewed changes

fix: update code

7d3596f

spacewander approved these changes Jan 21, 2022

View reviewed changes

juzhiyuan requested a review from shuaijinchao January 21, 2022 02:24

moonming reviewed Jan 21, 2022

View reviewed changes

shuaijinchao approved these changes Jan 21, 2022

View reviewed changes

bisakhmondal approved these changes Jan 21, 2022

View reviewed changes

spacewander merged commit 8114ca5 into apache:master Jan 21, 2022

guoqqqi deleted the feat-file-logger-plugin branch January 21, 2022 10:13

guoqqqi mentioned this pull request Jan 26, 2022

docs: add file-logger plugin info to README #6207

Merged

4 tasks



		function _M.body_filter(conf, ctx)
		log_util.collect_body(conf, ctx)

	uris = {"/plugin/file-logger/reopen"},
	uris = {"/v1/plugin/file-logger/reopen"},



		local function reopen()
		local target_pointer, err = io_open('logs/file_pointer', 'r')

	core.response.exit(400, {error_msg = "failed to open file, error info: " .. err})
	return 400, {error_msg = "failed to open file, error info: " .. err}

	local plugin_name = "file-logger"
	local plugin_name = "file-logger"

	file = io_open(conf.path, 'a+')
	local file, err = io_open(conf.path, 'a+')

	core.log.error("failed to open file: " .. conf.path .. ", error info: " .. err)
	core.log.error("failed to open file: ", conf.path, ", error info: ", err)

	local ok, error = file:write(msg)
	local ok, err = file:write(msg)


		## Name

		`file-logger` is a plugin which push a stream of Log data to a specified location. For example, the output path can be customized: `logs/file.log`.

	`file-logger` is a plugin which push a stream of Log data to a specified location. For example, the output path can be customized: `logs/file.log`.
	`file-logger` is a plugin that pushes a stream of log data to a specified file. For example, the output path can be customized: `logs/file.log`.



		function _M.log(conf, ctx)
		local metadata = plugin.plugin_metadata(plugin_name)

	local configs = {
	-- full configuration
	{
	endpoint = {
	uri = "http://127.0.0.1:18088/services/collector",
	token = "BD274822-96AA-4DA6-90EC-18940FB2414C",
	channel = "FE0ECFAD-13D5-401B-847D-77833BD77131",
	timeout = 60
	},
	max_retry_count = 0,
	retry_delay = 1,
	buffer_duration = 60,
	inactive_timeout = 2,
	batch_max_size = 10,
	},
	-- minimize configuration
	{
	endpoint = {
	uri = "http://127.0.0.1:18088/services/collector",
	token = "BD274822-96AA-4DA6-90EC-18940FB2414C",
	}
	},
	-- property "uri" is required
	{
	endpoint = {
	token = "BD274822-96AA-4DA6-90EC-18940FB2414C",
	}
	},
	-- property "token" is required
	{
	endpoint = {
	uri = "http://127.0.0.1:18088/services/collector",
	}
	},
	-- property "uri" validation failed
	{
	endpoint = {
	uri = "127.0.0.1:18088/services/collector",
	token = "BD274822-96AA-4DA6-90EC-18940FB2414C",
	}
	}
	}

	local plugin = require("apisix.plugins.splunk-hec-logging")
	for i = 1, #configs do
	ok, err = plugin.check_schema(configs[i])
	if err then
	ngx.say(err)
	else
	ngx.say("passed")
	end
	end
	}
	}

feat: add file-logger plugin #5831

feat: add file-logger plugin #5831

Conversation

guoqqqi commented Dec 16, 2021 • edited

What this PR does / why we need it:

Pre-submission checklist:

juzhiyuan commented Dec 16, 2021

guoqqqi commented Dec 20, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

spacewander Dec 31, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guoqqqi commented Jan 13, 2022

spacewander commented Jan 14, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guoqqqi Jan 20, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shuaijinchao left a comment

Choose a reason for hiding this comment

bisakhmondal left a comment

Choose a reason for hiding this comment

spacewander commented Jan 21, 2022

juzhiyuan commented Jan 21, 2022

feat: add `file-logger` plugin #5831

feat: add `file-logger` plugin #5831

guoqqqi commented Dec 16, 2021 •

edited

guoqqqi commented Dec 20, 2021 •

edited

spacewander Dec 31, 2021 •

edited

guoqqqi Jan 20, 2022 •

edited