Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: env.lua should use absolute path #6758

Merged
merged 1 commit into from Mar 31, 2022
Merged

fix: env.lua should use absolute path #6758

merged 1 commit into from Mar 31, 2022

Conversation

leslie-tsang
Copy link
Member

Description

The current env.lua uses CMD openresty to launch the service, which causes the master process unable to handle the USR2 signal properly.

This PR use absolute path CMD to handle it.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@spacewander spacewander merged commit b454ceb into apache:master Mar 31, 2022
@leslie-tsang leslie-tsang deleted the bugfix/fix-USR2-signal-exec-failed branch March 31, 2022 04:16
@leslie-tsang leslie-tsang mentioned this pull request Mar 31, 2022
Merged
5 tasks
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request May 20, 2022
@leslie-tsang @Liu-Junlin
fix: env.lua should use absolute path (apache#6758)
f74b6af
spacewander pushed a commit to spacewander/incubator-apisix that referenced this pull request May 23, 2022
@leslie-tsang @spacewander
fix: env.lua should use absolute path (apache#6758)
aa89e3e
spacewander pushed a commit to spacewander/incubator-apisix that referenced this pull request May 29, 2022
@leslie-tsang @spacewander
fix: env.lua should use absolute path (apache#6758)
b3ed3d5
spacewander pushed a commit that referenced this pull request May 29, 2022
@leslie-tsang @spacewander
fix: env.lua should use absolute path (#6758)
4fb1b7a
spacewander pushed a commit that referenced this pull request Jun 30, 2022
@leslie-tsang @spacewander
fix: env.lua should use absolute path (#6758)
e339e7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacewander spacewander spacewander approved these changes

@membphis membphis membphis approved these changes

@tzssangglass tzssangglass tzssangglass approved these changes

@nic-chen nic-chen nic-chen approved these changes

Assignees
No one assigned
Labels
need backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@leslie-tsang @spacewander @membphis @tzssangglass @nic-chen