New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support file-logger plugin of response body record #8414
Merged
spacewander
merged 11 commits into
apache:master
from
pixeldin:file-logger-plugin-supporting-response-record
Dec 9, 2022
Merged
feat: support file-logger plugin of response body record #8414
spacewander
merged 11 commits into
apache:master
from
pixeldin:file-logger-plugin-supporting-response-record
Dec 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixeldin
changed the title
Supporting file-logger plugin to record response body
feat: support file-logger plugin of response body record
Nov 28, 2022
tzssangglass
reviewed
Dec 5, 2022
tzssangglass
reviewed
Dec 5, 2022
…ogger-plugin-supporting-response-record
hi @pixeldin , we have error log as diff --git t/plugin/file-logger2.t t/plugin/file-logger2.t
index ccd1d9f5..ad4396c0 100644
--- t/plugin/file-logger2.t
+++ t/plugin/file-logger2.t
@@ -164,7 +164,6 @@ contain with target
if new_msg.response.body == "hello world\n"
then
- ngx.status = code
ngx.say('contain target body hits with expr')
end
@@ -174,7 +173,6 @@ contain with target
local new_msg = core.json.decode(msg)
if new_msg.response.body == nil
then
- ngx.status = code
ngx.say('skip unconcern body')
end
}
|
tzssangglass
reviewed
Dec 6, 2022
tzssangglass
previously approved these changes
Dec 6, 2022
spacewander
reviewed
Dec 7, 2022
tzssangglass
previously approved these changes
Dec 7, 2022
@tzssangglass please retrigger the CI workflow, the running state seems unstable. |
Done |
spacewander
reviewed
Dec 8, 2022
spacewander
reviewed
Dec 8, 2022
tzssangglass
approved these changes
Dec 9, 2022
spacewander
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Providing some optional setting items for file-logger to control the output log content as requested in #8331.
I refer some options of the http-logger:
include_req_body
,include_resp_body
andinclude_resp_body_expr
Checklist