Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: corrected minimum in healthcheck schema #8949

Conversation

Neilblaze
Copy link
Contributor

Description

It's meaningless to use zero as the minimum in schema_def.lua which was set to use as a default healthcheck in #5589.

Fixes #8937

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

cc: @spacewander, @navendu-pottekkat

@Neilblaze
Copy link
Contributor Author

@spacewander would you mind having a look at the (nginx) err that I'm facing from the CI test? I noticed that it's specifically because of these two :

error("failed to parse yaml config: " .. err)

@github-actions
Copy link

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.

@moonming
Copy link
Member

moonming commented Oct 9, 2023

@monkeyDluffy6017 please take a look

@monkeyDluffy6017
Copy link
Contributor

hi @Neilblaze, It's designed on purpose, when the configuration is set to 0, it will never report healthy status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

help request: the minimum in healthcheck schema is incorrect
3 participants