Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wolf-rbac): other plugin in consumer not effective when consumer used wolf-rbac plugin (#9287) #9298

Merged

Conversation

lingliy
Copy link
Contributor

@lingliy lingliy commented Apr 13, 2023

Description

Fixes # (issue)
#9287

Checklist

  • [ x ] I have explained the need for this PR and the problem it solves
  • [ x ] I have explained the changes or the new features added to this PR
  • [ x ] I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • [ x ] I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@lingliy lingliy force-pushed the fix-wolf-rbac-miss-attach_consumer branch 2 times, most recently from 7346a66 to bfd5311 Compare April 13, 2023 05:18
@lingliy lingliy changed the title Fixed missing consumer.attach_consumer in wolf-rbac plugin fix(wolf-rbac): other plugin not effective when consumer used wolf-rbac (#9287) Apr 13, 2023
@lingliy lingliy force-pushed the fix-wolf-rbac-miss-attach_consumer branch from bfd5311 to 96c4db6 Compare April 13, 2023 05:27
@lingliy lingliy changed the title fix(wolf-rbac): other plugin not effective when consumer used wolf-rbac (#9287) fix(wolf-rbac): other plugin in consumer not effective when consumer used wolf-rbac plugin (#9287) Apr 13, 2023
@monkeyDluffy6017
Copy link
Contributor

Hi @lingliy, test cases are needed!

@lingliy lingliy force-pushed the fix-wolf-rbac-miss-attach_consumer branch 6 times, most recently from dbb6c95 to fc69f3a Compare April 15, 2023 11:22
@lingliy
Copy link
Contributor Author

lingliy commented Apr 15, 2023

@monkeyDluffy6017 test cases have been written

@monkeyDluffy6017
Copy link
Contributor

@lingliy please fix the ci

@lingliy lingliy force-pushed the fix-wolf-rbac-miss-attach_consumer branch from fc69f3a to 97beacf Compare May 5, 2023 04:45
@monkeyDluffy6017 monkeyDluffy6017 merged commit f100cff into apache:master May 7, 2023
32 checks passed
@lingliy lingliy deleted the fix-wolf-rbac-miss-attach_consumer branch May 8, 2023 01:40
hongbinhsu added a commit to fitphp/apix that referenced this pull request May 13, 2023
* upstream/master: (42 commits)
  fix: add `rust-check` target to the makefile for deps pre-checking (apache#9453)
  test: remove duplicate `proto` unit test file and tweak test case title (apache#9445)
  feat: proxy-mirror add grpc and grpcs support (apache#9388)
  test: replace all httpbin upstream (apache#9452)
  fix: 404 error in ci test (apache#9447)
  fix: body-transformer plugin return raw body anytime (apache#9446)
  fix(ci): fips: ensure apisix compiles with openssl3 (apache#9427)
  chore(deps): bump actions/stale from 7 to 8 (apache#9159)
  chore(deps): bump actions/setup-node from 3.5.1 to 3.6.0 (apache#8625)
  chore(test): split the access log of apisix and test server (apache#8819)
  docs: fix grammar (apache#9395)
  fix(wolf-rbac): other plugin in consumer not effective when consumer used wolf-rbac plugin (apache#9287) (apache#9298)
  docs: use shell instead of Python to configure protos resources (apache#9414)
  docs: add guide to authenticate websocket connections (apache#9369)
  docs: updated Stream Proxy doc (apache#9367)
  feat: proxy_rewrite support miltiple regex pattern matching (apache#9194)
  feat: route-level MTLS (apache#9322)
  ci: tcp logger with real logger server (apache#9392)
  fix: always parse domain when host is domain name (apache#9332)
  docs: CHANGELOG.md Chinese docs lint (apache#9411)
  ...
AlinsRan pushed a commit to AlinsRan/apisix that referenced this pull request Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants