feat: add dubbo protocols support for xrpc #9660
Conversation
wxbty
changed the title
|
@nic-chen please help to check this |
|
hi @wxbty Thank you for your PR. Please add tests for the newly added features first, let's make sure the code works. Thanks ! |
|
@nic-chen added |
Co-authored-by: JunXu Chen <chenjunxu6@gmail.com>
Co-authored-by: JunXu Chen <chenjunxu6@gmail.com>
|
hi @wxbty CI failed, please have a look |
|
ok, deal with it later |
|
|
Hello, @wxbty |
|
Happy to discuss with you, wechat: wxb_101 |
|
Could you merge the master branch? |
monkeyDluffy6017
added
the
wait for update
.github/workflows/build.yml
Outdated
| @@ -137,7 +137,7 @@ jobs: | |||
| [[ ${{ steps.test_env.outputs.type }} != first ]] && sudo ./ci/init-${{ steps.test_env.outputs.type }}-test-service.sh after | |||
| echo "Linux launch services, done." | |||
| - name: Start Dubbo Backend | |||
| if: matrix.os_name == 'linux_openresty' && steps.test_env.outputs.type == 'plugin' | |||
| if: matrix.os_name == 'linux_openresty' && [steps.test_env.outputs.type == 'plugin' || steps.test_env.outputs.type == 'xrpc'] | |||
There was a problem hiding this comment.
https://github.com/apache/apisix/actions/runs/5751049180
Incorrect expression caused the CI to be skipped, please fix it.
ok |
|
@monkeyDluffy6017 PTAL |
|
@wxbty ok, i will check this later |
monkeyDluffy6017
added
approved
and removed
wait for update
Description
Add dubbo protocol extension to apisix
Fixes #8352