Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: lmdb support #46

Closed
wants to merge 17 commits into from
Closed

WIP: lmdb support #46

wants to merge 17 commits into from

Commits on Sep 27, 2023

  1. Initial commit for lmdb support

    @uhliarik
    uhliarik committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    f0379e7 View commit details
    Browse the repository at this point in the history

  2. Add -llmdb 

    Add -llmdb to test/Makefile.in so test can be compiled without
any error.
    @uhliarik
    uhliarik committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    e147886 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Remove lmdb driver from build.conf and revert e147886 

    - Remove lmdb driver from build.conf so it won't get linked twice!
- Revert e147886
    @uhliarik
    uhliarik committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    ad34f18 View commit details
    Browse the repository at this point in the history

  2. Removed wrong lines from build.conf in ad34f18 

    - Removed wrong lines from build.conf in ad34f18. Revering and
  removing correct line
    @uhliarik
    uhliarik committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    fcf0580 View commit details
    Browse the repository at this point in the history

  3. Pass the -lock file back via _usednames. This seems to be reliable 

    if using MDB_NOSUBDIR per http://www.lmdb.tech/doc/group__mdb.html#ga32a193c6bf4d7d5c5d579e71f22e9340
    @notroj
    notroj committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    c1e6ae7 View commit details
    Browse the repository at this point in the history

  4. Pass the -lock file back via _usednames. This seems to be reliable 

    if using MDB_NOSUBDIR per http://www.lmdb.tech/doc/group__mdb.html#ga32a193c6bf4d7d5c5d579e71f22e9340

Merging the change suggested by @notroj
apache@26afe6b
    @uhliarik
    uhliarik committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    7bf4a66 View commit details
    Browse the repository at this point in the history

  5. Move #include <lmdb.h> inside conditional.

    @notroj
    notroj committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    61a15b8 View commit details
    Browse the repository at this point in the history

  6. Add LMDB test build.

    @notroj
    notroj committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    d5c6f8a View commit details
    Browse the repository at this point in the history

  7. Use --with-lmdb for LMDB test build (duh).

    @notroj
    notroj committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    45bf67d View commit details
    Browse the repository at this point in the history

  8. Fix Debian package name.

    @notroj
    notroj committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    11fee2b View commit details
    Browse the repository at this point in the history

  9. Fix GCC warnings.

    @notroj
    notroj committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    43bcfef View commit details
    Browse the repository at this point in the history

  10. Add BDB test.

    @notroj
    notroj committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    6df0b13 View commit details
    Browse the repository at this point in the history

  11. Remove unnecessary apr_dbm_t struct and add test for opening 

    a non-existent database.
    @notroj
    notroj committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    f10d2ce View commit details
    Browse the repository at this point in the history

  12. Simplify error handling - since mdb_* can return errno as positive 

    (just like apr_status_t) map those values directly; map all
other errors as APR_EGENERAL.

APR-internal APIs should not use error codes within the
APR_OS_START_USEERR number region (mistake common to dbm/*.c.)
    @notroj
    notroj committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    f8f484d View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Default to using MDB_NOSYNC when opening the database to avoid 

    overhead of per-transaction fdatasync() calls, bringing comparable
behaviour/performance to BDB etc.

Arguably this behaviour could be controlled by a new flag passed
in the mode parameter of apr_dbm_open*.
    @notroj
    notroj committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    49e1023 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from notroj/lmdb_support 

    Lmdb support
    @uhliarik
    uhliarik committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    e142d06 View commit details
    Browse the repository at this point in the history

  3. Remove lmdb_retry function 

    which was originally used for dynamic database resizing in case the
database was full.

This function is no longer used and the size of the database is set
to UINT32_MAX in vt_lmdb_open() function.
    @uhliarik
    uhliarik committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    3a539c1 View commit details
    Browse the repository at this point in the history