Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apr_file_pipe_create() - save more syscalls with pipe2() #56

Closed
wants to merge 1 commit into from
Closed

apr_file_pipe_create() - save more syscalls with pipe2() #56

wants to merge 1 commit into from

Conversation

notroj
Copy link
Contributor

@notroj notroj commented May 10, 2024 

* file_io/unix/pipe.c (file_pipe_create): Use pipe2(,O_NONBLOCK) by
  default unless APR_FULL_BLOCK was used; unconditionally set the
  blocking state later. Saves two syscalls per invocation for both
  APR_READ_BLOCK and APR_WRITE_BLOCK, no [intended] functional change.

@notroj
* file_io/unix/pipe.c (file_pipe_create): Use pipe2(,O_NONBLOCK) by
9051fa1 
  default unless APR_FULL_BLOCK was used; unconditionally set the
  blocking state later. Saves two syscalls per invocation for both
  APR_READ_BLOCK and APR_WRITE_BLOCK, no [intended] functional change.
@notroj
Copy link
Contributor Author

notroj commented Jun 11, 2024

Merged in 639ad0b

@notroj notroj closed this Jun 11, 2024
@notroj
Copy link
Contributor Author

notroj commented Jun 11, 2024

Err, no it wasn't.

@notroj notroj reopened this Jun 11, 2024
@asfgit asfgit closed this in e395624 Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@notroj