test(csharp): add more tests for verifying GetObjects (Depths and Patterns) #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added tests to verify GetObjects for different depths like: Catalogs DbSchemas Tables All Also added tests to verify GetObjects with catalog, schema, and table names passed as patterns
lidavidm
changed the title
jduo
reviewed
Nov 15, 2023
|
|
||
| string databaseName = testConfiguration.Metadata.Catalog; | ||
| string schemaName = testConfiguration.Metadata.Schema; | ||
| string partialDatabaseName = $"{GetPartialNameForPatternMatch(databaseName)}%"; |
There was a problem hiding this comment.
We should test a variety of wildcards and also test if case-sensitivity (or insensitivity) is handled correctly.
There was a problem hiding this comment.
Also, check that we handle embedded special characters like single-quote safely.
…and check that database object starts with the pattern name
jduo
reviewed
Nov 16, 2023
davidhcoe
reviewed
Nov 17, 2023
zeroshade
pushed a commit
that referenced
this pull request
Nov 17, 2023
…ters are provided (#1285) ## Replaced some cursor calls with static calls and filtered early when possible If a share isn't associated with a database then SELECT DATABASE_NAME FROM INFORMATION_SCHEMA.DATABASES call will not list it and therefore it doesn't seem necessary to call SHOW SHARES LIKE '%database_name%' to get a list and check if a DB isn't created for it. Therefore, those checks were removed. ### Comparison of performance improvements: I have created another PR: #1299 with additional tests for `GetObjects`. | Test | Before | After | % Improvement | |-----|---------------------|------------------|-------------------| | CanGetObjectsAll | 17.6 s | 3 s | 82.5 | | CanGetObjectsCatalogs | 503 ms | 333 ms | 33.80 | | CanGetObjectsCatalogsWithPattern | 421 ms | 369 ms | 12.35 | | CanGetObjectsDbSchemas | 4.4 s | 694 ms | 84.36 | | CanGetObjectsDbSchemasWithPattern | 4 s | 807 ms | 79.825 | | CanGetObjectsTables | 18 s | 2.8 s | 84.44 | | CanGetObjectsTablesWithPattern | 17.6 s | 2.9 s | 83.52 |
|
@jduo or @ryan-syed -- anything else needed here before merging? |
I think it should be good. Unable to add tests for case-sensitivity in patterns for GetObjects, as the spec is not clear about it. Also, as mentioned, the driver implementation uses |
|
Created an issue for case sensitivity: #1314 |
CurtHagenlocher
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests to verify GetObjects for different depths like: Catalogs
DbSchemas
Tables
All
Also added tests to verify GetObjects with catalog, schema, and table names passed as patterns