ci: auto-assign milestones to pull requests #1301
Conversation
|
Demo: lidavidm#6 |
|
CC @kou, what do you think? |
.github/workflows/dev_pr.yml
Outdated
| @@ -38,6 +38,7 @@ jobs: | |||
| persist-credentials: false | |||
|
|
|||
| - name: Check title for Conventional Commits format | |||
| continue-on-error: true | |||
There was a problem hiding this comment.
If we add this, this workflow may not report an error with unexpected title...
There was a problem hiding this comment.
It currently reports an error via a comment, though I'd like to change that (#1294). But you're right, it looks like the right way to do this is if: always()
| echo "Latest tagged version: ${latest_version}" | ||
| echo "Assigning milestone: ${milestone}" | ||
|
|
||
| gh pr edit "${pr_number}" -m "${milestone}" |
There was a problem hiding this comment.
This may override already assigned milestone. Is it intentional?
If it's not intentional, we may want to assign a milestone only when the PR isn't assigned to any milestone.
There was a problem hiding this comment.
Ah, good point. Maybe it would be best to only run this post-merge: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#running-your-pull_request-workflow-when-a-pull-request-merges
There was a problem hiding this comment.
Though we don't have to do that, and we can just only assign a milestone if one isn't already assigned.
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
|
Updated. Demo: https://github.com/lidavidm/arrow-adbc/actions/runs/6892276485/job/18749174958?pr=7 (It gets a little confused on my fork because I have branches like |
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Fixes #1296.