Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rust): add driver manager and ability to expose Rust driver as C driver #1496

Closed
wants to merge 33 commits into from
Closed

feat(rust): add driver manager and ability to expose Rust driver as C driver #1496

wants to merge 33 commits into from

Commits on Apr 6, 2024

  1. wip: write rust driver_manager 

    wip: add implement module

fix: implement drop for FFI_AdbcError

fix: address lifetime of nullable strings passed in ffi

wip: implement get_info utilities

feat: add better API for database objects

feat: export objects collection

refactor: remove tabular generic

refactor: use concrete error type

refactor: make less ffi-centric
    @wjones127 @alexandreyc
    wjones127 authored and alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    6b5fc13 View commit details
    Browse the repository at this point in the history

  2. Update dependencies

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    744d7cd View commit details
    Browse the repository at this point in the history

  3. Fix some imports

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    5f155c5 View commit details
    Browse the repository at this point in the history

  4. Remove async methods from core traits

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    f29a15a View commit details
    Browse the repository at this point in the history

  5. Remove non_camel_case_types warnings for ffi module

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    f197992 View commit details
    Browse the repository at this point in the history

  6. Update import_info_data to return correct type

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    64ace05 View commit details
    Browse the repository at this point in the history

  7. Update objects module to comply with newer Arrow API

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    c5814e2 View commit details
    Browse the repository at this point in the history

  8. Update bind_data to take &StructArray instead of RecordBatch

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    11af059 View commit details
    Browse the repository at this point in the history

  9. Make the code compile

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    b96d409 View commit details
    Browse the repository at this point in the history

  10. cargo fmt

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    8671d56 View commit details
    Browse the repository at this point in the history

  11. Minor refactor of SchemaRef

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    d1acc3a View commit details
    Browse the repository at this point in the history

  12. Refactor info module and add support for all info data types

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    1c9b3fe View commit details
    Browse the repository at this point in the history

  13. Improve conversion from ArrowError to AdbcError

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    1e00942 View commit details
    Browse the repository at this point in the history

  14. Minor improvments to driver_manager module

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    f0aea1b View commit details
    Browse the repository at this point in the history

  15. Fix doctest in ffi module

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    2861354 View commit details
    Browse the repository at this point in the history

  16. Fix doctest in root module

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    f2952e8 View commit details
    Browse the repository at this point in the history

  17. Ignore test test_connection_get_info

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    0c79642 View commit details
    Browse the repository at this point in the history

  18. Move new_statement implementation to trait for DriverConnection

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    014d27d View commit details
    Browse the repository at this point in the history

  19. Fix clippy warnings

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    ad9f2d1 View commit details
    Browse the repository at this point in the history

  20. Remove unnecessary Result return type when building DriverDatabase

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    a464193 View commit details
    Browse the repository at this point in the history

  21. Add impl AdbcDatabase for DriverDatabase

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    d9b8876 View commit details
    Browse the repository at this point in the history

  22. Refactor get_table_types

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    aec999a View commit details
    Browse the repository at this point in the history

  23. Fix typo in docstring

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    be4df25 View commit details
    Browse the repository at this point in the history

  24. Minor improvements to driver manager's tests

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    93a47fd View commit details
    Browse the repository at this point in the history

  25. Fix typo in docstring

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    826dd26 View commit details
    Browse the repository at this point in the history

  26. Fix bug when setting options to connection instead of database

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    3342583 View commit details
    Browse the repository at this point in the history

  27. Fix clippy warning

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    7e06d5e View commit details
    Browse the repository at this point in the history

  28. Fix some docstrings

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    c8cd23e View commit details
    Browse the repository at this point in the history

  29. Use type alias everywhere

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    ec650f4 View commit details
    Browse the repository at this point in the history

  30. Fix bug when interpreting slice of InfoData as slice of u32

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    d6010b0 View commit details
    Browse the repository at this point in the history

  31. Add test for connection_get_objects and fix bugs when building object… 

    … arrays
    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    25b5f56 View commit details
    Browse the repository at this point in the history

  32. Fix to call release callbacks

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    f0f7c8d View commit details
    Browse the repository at this point in the history

  33. Add missing call to DatabaseInit

    @alexandreyc
    alexandreyc committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    1ee7b6d View commit details
    Browse the repository at this point in the history