Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-13716: Add RecordBatch recipe #66

Merged
merged 4 commits into from Sep 15, 2021
Merged

ARROW-13716: Add RecordBatch recipe #66

merged 4 commits into from Sep 15, 2021

Conversation

amol-
Copy link
Contributor

@amol- amol- commented Sep 2, 2021

westonpace
westonpace requested changes Sep 7, 2021
View reviewed changes
Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Just a few grammatical/wording suggestions.

python/source/create.rst Outdated Show resolved Hide resolved
python/source/create.rst Outdated Show resolved Hide resolved
python/source/create.rst Outdated Show resolved Hide resolved
python/source/create.rst Outdated Show resolved Hide resolved
python/source/create.rst Outdated Show resolved Hide resolved
python/source/create.rst Outdated Show resolved Hide resolved
amol- and others added 2 commits September 13, 2021 11:58
@amol- @westonpace
Apply suggestions from code review
2fede5d 
Co-authored-by: Weston Pace <weston.pace@gmail.com>
@amol-
Make example obvious
dcd187a
thisisnic
thisisnic reviewed Sep 15, 2021
View reviewed changes
python/source/create.rst Outdated Show resolved Hide resolved
thisisnic
thisisnic reviewed Sep 15, 2021
View reviewed changes
python/source/create.rst Outdated Show resolved Hide resolved
thisisnic
thisisnic approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@thisisnic thisisnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny rephrasing suggestions, otherwise LGTM

@amol- @thisisnic
Apply suggestions from code review
f91adbc 
Co-authored-by: Nic <thisisnic@gmail.com>
@thisisnic thisisnic merged commit aa1c1b2 into apache:main Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonpace westonpace westonpace requested changes

@thisisnic thisisnic thisisnic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amol- @westonpace @thisisnic