Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFrame.collect() should return async stream rather than a Vec<RecordBatch> #47

Closed
andygrove opened this issue Apr 24, 2021 · 2 comments · Fixed by #789
Closed

DataFrame.collect() should return async stream rather than a Vec<RecordBatch> #47

andygrove opened this issue Apr 24, 2021 · 2 comments · Fixed by #789
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@andygrove
Copy link
Member

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Currently, any DataFrame implementation must load the entire result set into RAM in the collect() method because it has to return a Vec<RecordBatch>.

Describe the solution you'd like
Change the signature to return an async stream of batches.

Describe alternatives you've considered
None

Additional context
None

@andygrove andygrove added enhancement New feature or request good first issue Good for newcomers labels Apr 24, 2021
@kination
Copy link
Contributor

@andygrove hope to touch on this if it's not on work yet 🙏

@kination
Copy link
Contributor

kination commented May 23, 2021

@andygrove currently collect is collecting SendableRecordBatchStream to Vector inside function before returning.

let it: SendableRecordBatchStream = plan.execute(0).await?;
common::collect(it).await

Are you intend to make this not collecting before return?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants