refactor sort exec stream and combine batches #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #515 +/- ##
==========================================
+ Coverage 76.09% 76.11% +0.02%
==========================================
Files 155 155
Lines 26575 26602 +27
==========================================
+ Hits 20221 20249 +28
+ Misses 6354 6353 -1
Continue to review full report at Codecov.
|
Jimexist
force-pushed
the
refactor-combine-batches
branch
2 times, most recently
from
49ddfd3
to
a0430e1
Compare
houqp
approved these changes
Jun 6, 2021
Jimexist
commented
Jun 6, 2021
| // sort combined record batch | ||
| let result = combined | ||
| .map(|batch| sort_batch(batch, schema, &expr)) | ||
| .transpose()?; | ||
| sort_time.add(now.elapsed().as_nanos() as usize); |
There was a problem hiding this comment.
Note here the semantic is changed because on err it would no longer log a metric which shall be the correct behavior
Jimexist
force-pushed
the
refactor-combine-batches
branch
from
a0430e1
to
248ba2f
Compare
Jimexist
force-pushed
the
refactor-combine-batches
branch
from
248ba2f
to
de4055b
Compare
alamb
reviewed
Jun 7, 2021
houqp
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
to make way for #360 I'll need the combine batches fn, so i'll refactor the current sort exec stream and add some integration test by the way
this pull request is used by #516
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?