Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Jun 6, 2022

This is my test that sqlparser 0.18.0 is good to go -- it only required very minor changes to DataFusion -- see 30ae5df

Updates DataFusion to use sqlparser 0.18.0 -- see changelog https://github.com/sqlparser-rs/sqlparser-rs/blob/main/CHANGELOG.md#0180-2022-06-06

[0.18.0] 2022-06-06

Added

Changed:

Fixed:

@github-actions github-actions bot added the sql SQL Planner label Jun 6, 2022
@alamb alamb force-pushed the alamb/update_parser branch from 30ae5df to a4d55db Compare June 6, 2022 21:06
@github-actions github-actions bot added core Core DataFusion crate logical-expr Logical plan and expressions labels Jun 6, 2022
@alamb alamb changed the title Demonstration of updating sqlparser-rs to pre-release 0.18.0 Updating sqlparser-rs to 0.18.0 Jun 6, 2022
@alamb alamb marked this pull request as ready for review June 6, 2022 21:08
@alamb alamb changed the title Updating sqlparser-rs to 0.18.0 Update sqlparser-rs to 0.18.0 Jun 6, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2705 (a4d55db) into master (3cd62e9) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2705      +/-   ##
==========================================
- Coverage   84.66%   84.66%   -0.01%     
==========================================
  Files         270      270              
  Lines       46919    46919              
==========================================
- Hits        39726    39723       -3     
- Misses       7193     7196       +3     
Impacted Files Coverage Δ
datafusion/sql/src/planner.rs 81.52% <100.00%> (ø)
datafusion/expr/src/window_frame.rs 92.43% <0.00%> (-0.85%) ⬇️
datafusion/expr/src/logical_plan/plan.rs 74.35% <0.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cd62e9...a4d55db. Read the comment docs.

@yjshen yjshen merged commit 1cd6ede into apache:master Jun 7, 2022
@alamb alamb deleted the alamb/update_parser branch June 7, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants