Cleanup and actually run integration tests with testing suite #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial integration tests were throw together before the latest big refactoring, and I didn't bother to see if they worked or not before merging since we weren't actually running the tests anyway. Here, ArrowJSON module is cleaned up and the integration tests are actually run to ensure everything passes/works.
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
+ Coverage 80.78% 81.24% +0.46%
==========================================
Files 14 14
Lines 2612 2613 +1
==========================================
+ Hits 2110 2123 +13
+ Misses 502 490 -12
Continue to review full report at Codecov.
|
quinnj
added a commit
that referenced
this pull request
Oct 3, 2020
* Cleanup and actually run integration tests with testing suite The initial integration tests were throw together before the latest big refactoring, and I didn't bother to see if they worked or not before merging since we weren't actually running the tests anyway. Here, ArrowJSON module is cleaned up and the integration tests are actually run to ensure everything passes/works. * fix test deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial integration tests were throw together before the latest big
refactoring, and I didn't bother to see if they worked or not before
merging since we weren't actually running the tests anyway. Here,
ArrowJSON module is cleaned up and the integration tests are actually
run to ensure everything passes/works.