Skip to content

Commit

Permalink
remove Vec::with_capacity because resize is done afterward
Browse files Browse the repository at this point in the history
  • Loading branch information
Ye Yuan committed May 4, 2024
1 parent 2829d21 commit 345991c
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions parquet_derive/src/parquet_field.rs
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ impl Field {
let write_batch_expr = quote! {
let mut vals = Vec::new();
if let #column_reader(mut typed) = column_reader {
let mut definition_levels = Vec::with_capacity(num_records);
let mut definition_levels = Vec::new();
let (total_num, valid_num, decoded_num) = typed.read_records(
num_records, Some(&mut definition_levels), None, &mut vals)?;
if valid_num != decoded_num {
Expand Down Expand Up @@ -865,7 +865,7 @@ mod test {
{
let mut vals = Vec::new();
if let ColumnReader::Int64ColumnReader(mut typed) = column_reader {
let mut definition_levels = Vec::with_capacity(num_records);
let mut definition_levels = Vec::new();
let (total_num, valid_num, decoded_num) = typed.read_records(
num_records, Some(&mut definition_levels), None, &mut vals)?;
if valid_num != decoded_num {
Expand Down Expand Up @@ -1248,7 +1248,7 @@ mod test {
{
let mut vals = Vec::new();
if let ColumnReader::Int64ColumnReader(mut typed) = column_reader {
let mut definition_levels = Vec::with_capacity(num_records);
let mut definition_levels = Vec::new();
let (total_num, valid_num, decoded_num) = typed.read_records(
num_records, Some(&mut definition_levels), None, &mut vals)?;
if valid_num != decoded_num {
Expand Down Expand Up @@ -1322,7 +1322,7 @@ mod test {
{
let mut vals = Vec::new();
if let ColumnReader::Int32ColumnReader(mut typed) = column_reader {
let mut definition_levels = Vec::with_capacity(num_records);
let mut definition_levels = Vec::new();
let (total_num, valid_num, decoded_num) = typed.read_records(
num_records, Some(&mut definition_levels), None, &mut vals)?;
if valid_num != decoded_num {
Expand Down Expand Up @@ -1396,7 +1396,7 @@ mod test {
{
let mut vals = Vec::new();
if let ColumnReader::ByteArrayColumnReader(mut typed) = column_reader {
let mut definition_levels = Vec::with_capacity(num_records);
let mut definition_levels = Vec::new();
let (total_num, valid_num, decoded_num) = typed.read_records(
num_records, Some(&mut definition_levels), None, &mut vals)?;
if valid_num != decoded_num {
Expand Down

0 comments on commit 345991c

Please sign in to comment.