Skip to content

Commit

Permalink
remove redundant CI benchmark check, cleanups (#2212)
Browse files Browse the repository at this point in the history
* remove redundant CI benchmark check, cleanups

* cleanup

* Clarify the intent of parquet library compilation check, and add missing case

* Update .github/workflows/parquet.yml

Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>

Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
  • Loading branch information
alamb and tustvold committed Jul 28, 2022
1 parent 8139f7b commit 48cc6c3
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 37 deletions.
22 changes: 18 additions & 4 deletions .github/workflows/parquet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,17 @@ jobs:
uses: ./.github/actions/setup-builder
with:
rust-version: stable

# Run different tests for the library on its own as well as
# all targets to ensure that it still works in the absence of
# features that might be enabled by dev-dependencies of other
# targets.
#
# This for each of (library and all-targets), check
# 1. compiles with default features
# 1. compiles with no default features
# 3. compiles with just arrow feature
# 3. compiles with all features
- name: Check compilation
run: |
cargo check -p parquet
Expand All @@ -91,12 +102,15 @@ jobs:
- name: Check compilation --all-targets
run: |
cargo check -p parquet --all-targets
- name: Check compilation --no-default-features --all-targets
- name: Check compilation --all-targets --no-default-features
run: |
cargo check -p parquet --all-targets --no-default-features
- name: Check compilation --all-targets --no-default-features --features arrow
run: |
cargo check -p parquet --no-default-features --all-targets
- name: Check compilation --no-default-features --features-arrow --all-targets
cargo check -p parquet --all-targets --no-default-features --features arrow
- name: Check compilation --all-targets --all-features
run: |
cargo check -p parquet --no-default-features --features arrow --all-targets
cargo check -p parquet --all-targets --all-features
clippy:
name: Clippy
Expand Down
33 changes: 0 additions & 33 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,36 +47,10 @@ jobs:
- name: Run tests
shell: bash
run: |
export ARROW_TEST_DATA=$(pwd)/testing/data
export PARQUET_TEST_DATA=$(pwd)/parquet-testing/data
# do not produce debug symbols to keep memory usage down
export RUSTFLAGS="-C debuginfo=0"
cargo test
check_benches:
name: Check Benchmarks (but don't run them)
runs-on: ubuntu-latest
strategy:
matrix:
arch: [ amd64 ]
rust: [ stable ]
container:
image: ${{ matrix.arch }}/rust
env:
# Disable full debug symbol generation to speed up CI build and keep memory down
# "1" means line tables only, which is useful for panic tracebacks.
RUSTFLAGS: "-C debuginfo=1"
steps:
- uses: actions/checkout@v2
with:
submodules: true
- name: Setup Rust toolchain
uses: ./.github/actions/setup-builder
with:
rust-version: ${{ matrix.rust }}
- name: Check benchmarks
run: |
cargo check --benches --workspace --features test_common,prettyprint,async,experimental
# Run cargo fmt for all crates
lint:
Expand Down Expand Up @@ -113,16 +87,9 @@ jobs:
uses: actions/cache@v3
with:
path: /home/runner/.cargo
# this key is not equal because the user is different than on a container (runner vs github)
key: cargo-coverage-cache3-
- name: Run coverage
run: |
export CARGO_HOME="/home/runner/.cargo"
export CARGO_TARGET_DIR="/home/runner/target"
export ARROW_TEST_DATA=$(pwd)/testing/data
export PARQUET_TEST_DATA=$(pwd)/parquet-testing/data
rustup toolchain install stable
rustup default stable
cargo install --version 0.18.2 cargo-tarpaulin
Expand Down

0 comments on commit 48cc6c3

Please sign in to comment.