remove redundant CI benchmark check, cleanups

apache · Jul 28, 2022 · 6be18e2 · 6be18e2
1 parent bc493d9
commit 6be18e2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 47 deletions.
diff --git a/.github/workflows/parquet.yml b/.github/workflows/parquet.yml
@@ -72,26 +72,17 @@ jobs:
         with:
           rust-version: stable
       - name: Check compilation
-        run: |
-          cargo check -p parquet
-      - name: Check compilation --no-default-features
-        run: |
-          cargo check -p parquet --no-default-features
-      - name: Check compilation --no-default-features --features arrow
-        run: |
-          cargo check -p parquet --no-default-features --features arrow
-      - name: Check compilation --no-default-features --all-features
-        run: |
-          cargo check -p parquet --all-features
-      - name: Check compilation --all-targets
         run: |
           cargo check -p parquet --all-targets
       - name: Check compilation --no-default-features --all-targets
         run: |
           cargo check -p parquet --no-default-features --all-targets
-      - name: Check compilation --no-default-features --features-arrow --all-targets
+      - name: Check compilation --no-default-features --features arrow --all-targets
         run: |
           cargo check -p parquet --no-default-features --features arrow --all-targets
+      - name: Check compilation --all-features --all-targets
+        run: |
+          cargo check -p parquet --all-features --all-targets
 
   clippy:
     name: Clippy

diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
@@ -44,37 +44,10 @@ jobs:
       - name: Run tests
         shell: bash
         run: |
-          export ARROW_TEST_DATA=$(pwd)/testing/data
-          export PARQUET_TEST_DATA=$(pwd)/parquet-testing/data
           # do not produce debug symbols to keep memory usage down
           export RUSTFLAGS="-C debuginfo=0"
           cargo test
 
-  check_benches:
-    name: Check Benchmarks (but don't run them)
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        arch: [ amd64 ]
-        rust: [ stable ]
-    container:
-      image: ${{ matrix.arch }}/rust
-      env:
-        # Disable full debug symbol generation to speed up CI build and keep memory down
-        # "1" means line tables only, which is useful for panic tracebacks.
-        RUSTFLAGS: "-C debuginfo=1"
-    steps:
-      - uses: actions/checkout@v2
-        with:
-          submodules: true
-      - name: Setup Rust toolchain
-        uses: ./.github/actions/setup-builder
-        with:
-          rust-version: ${{ matrix.rust }}
-      - name: Check benchmarks
-        run: |
-          cargo check --benches --workspace --features test_common,prettyprint,async,experimental
-
   lint:
     name: Lint (cargo fmt)
     runs-on: ubuntu-latest
@@ -109,16 +82,9 @@ jobs:
         uses: actions/cache@v3
         with:
           path: /home/runner/.cargo
-          # this key is not equal because the user is different than on a container (runner vs github)
           key: cargo-coverage-cache3-
       - name: Run coverage
         run: |
-          export CARGO_HOME="/home/runner/.cargo"
-          export CARGO_TARGET_DIR="/home/runner/target"
-
-          export ARROW_TEST_DATA=$(pwd)/testing/data
-          export PARQUET_TEST_DATA=$(pwd)/parquet-testing/data
-
           rustup toolchain install stable
           rustup default stable
           cargo install --version 0.18.2 cargo-tarpaulin

diff --git a/parquet/benches/arrow_reader.rs b/parquet/benches/arrow_reader.rs
@@ -692,3 +692,4 @@ fn add_benches(c: &mut Criterion) {
 
 criterion_group!(benches, add_benches);
 criterion_main!(benches);
+