REname is_int_type to is_dictionary_key_type()

apache · Nov 4, 2021 · 8acd8d2 · 8acd8d2
1 parent 5c8da87
commit 8acd8d2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/arrow/src/array/data.rs b/arrow/src/array/data.rs
@@ -673,7 +673,7 @@ impl ArrayData {
             }
             DataType::Dictionary(key_type, _value_type) => {
                 // At the moment, constructing a DictionaryArray will also check this
-                if !DataType::is_integer(key_type) {
+                if !DataType::is_dictionary_key_type(key_type) {
                     return Err(ArrowError::InvalidArgumentError(format!(
                         "Dictionary values must be integer, but was {}",
                         key_type

diff --git a/arrow/src/datatypes/datatype.rs b/arrow/src/datatypes/datatype.rs
@@ -477,8 +477,9 @@ impl DataType {
         )
     }
 
-    /// Returns true if this type is integral: (UInt*, Unit*).
-    pub fn is_integer(t: &DataType) -> bool {
+    /// Returns true if this type is valid as a dictionary key
+    /// (e.g. [`super::ArrowDictionaryKeyType`]
+    pub fn is_dictionary_key_type(t: &DataType) -> bool {
         use DataType::*;
         matches!(
             t,