Fix object_store lint (#2367)

apache · Aug 8, 2022 · beaef5c · beaef5c
1 parent 3f5ab6b
commit beaef5c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/.github/workflows/object_store.yml b/.github/workflows/object_store.yml
@@ -44,7 +44,7 @@ jobs:
           rustup component add clippy
       - name: Run clippy
         run: |
-          cargo clippy -p object_store --all-features
+          cargo clippy -p object_store --all-features -- -D warnings
 
   # test the crate
   linux-test:

diff --git a/object_store/src/util.rs b/object_store/src/util.rs
@@ -84,8 +84,8 @@ pub async fn coalesce_ranges<F, Fut>(
     coalesce: usize,
 ) -> Result<Vec<Bytes>>
 where
-    F: FnMut(std::ops::Range<usize>) -> Fut,
-    Fut: std::future::Future<Output = Result<Bytes>>,
+    F: Send + FnMut(std::ops::Range<usize>) -> Fut,
+    Fut: std::future::Future<Output = Result<Bytes>> + Send,
 {
     let mut ret = Vec::with_capacity(ranges.len());
     let mut start_idx = 0;
@@ -105,8 +105,7 @@ where
         let start = ranges[start_idx].start;
         let end = ranges[end_idx - 1].end;
         let bytes = fetch(start..end).await?;
-        for i in start_idx..end_idx {
-            let range = ranges[i].clone();
+        for range in ranges.iter().take(end_idx).skip(start_idx) {
             ret.push(bytes.slice(range.start - start..range.end - start))
         }
         start_idx = end_idx;