Don't panic on RleValueEncoder::flush_buffer if empty (#2558) (#2559)

apache · Aug 23, 2022 · f11fc1f · f11fc1f
1 parent ad84176
commit f11fc1f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/parquet/src/arrow/arrow_reader/mod.rs b/parquet/src/arrow/arrow_reader/mod.rs
@@ -1355,6 +1355,10 @@ mod tests {
             TestOptions::new(2, 256, 91)
                 .with_null_percent(25)
                 .with_enabled_statistics(EnabledStatistics::None),
+            // Test with all null
+            TestOptions::new(2, 128, 91)
+                .with_null_percent(100)
+                .with_enabled_statistics(EnabledStatistics::None),
             // Test skip
 
             // choose record_batch_batch (15) so batches cross row

diff --git a/parquet/src/encodings/encoding/mod.rs b/parquet/src/encodings/encoding/mod.rs
@@ -232,7 +232,7 @@ impl<T: DataType> Encoder<T> for RleValueEncoder<T> {
 
         // Flush all encoder buffers and raw values
         let mut buf = rle_encoder.consume();
-        assert!(buf.len() > 4, "should have had padding inserted");
+        assert!(buf.len() >= 4, "should have had padding inserted");
 
         // Note that buf does not have any offset, all data is encoded bytes
         let len = (buf.len() - 4) as i32;