Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dyn scalar comparison kernels #1113

Closed
15 tasks
matthewmturner opened this issue Dec 31, 2021 · 4 comments · Fixed by #1114, #1115, #1116, #1117 or #1118
Closed
15 tasks

Implement dyn scalar comparison kernels #1113

matthewmturner opened this issue Dec 31, 2021 · 4 comments · Fixed by #1114, #1115, #1116, #1117 or #1118
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@matthewmturner
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Following the design set in #1074 we would like to add the remaining dynamic comparison kernels.

Scalar

  • lt_dyn_scalar
  • lt_eq_dyn_scalar
  • gt_dyn_scalar
  • gt_eq_dyn_scalar
  • neq_dyn_scalar

UTF8 Scalar

  • lt_dyn_utf8_scalar
  • lt_eq_dyn_utf8_scalar
  • gt_dyn_utf8_scalar
  • gt_eq_dyn_utf8_scalar
  • neq_dyn_utf8_scalar

Boolean

  • lt_dyn_bool_scalar
  • lt_eq_dyn_bool_scalar
  • gt_dyn_bool_scalar
  • gt_eq_dyn_bool_scalar
  • neq_dyn_bool_scalar

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@matthewmturner matthewmturner added the enhancement Any new improvement worthy of a entry in the changelog label Dec 31, 2021
@matthewmturner matthewmturner changed the title Implement dyn comparison kernels Implement dyn scalar comparison kernels Dec 31, 2021
@matthewmturner
Copy link
Contributor Author

@alamb @liukun4515

I am submitting a bunch of the PRs now branching off my existing eq_dyn_scalar branch. The PRs now currently show all the changes because we havent merged that one in to master yet. Im hoping once that is merged i can simply rebase and these will be good to go.

@matthewmturner
Copy link
Contributor Author

Going to stop here at the scalar kernels to make sure all good. If this approach is good ill do the utf8 and bool kernels

@liukun4515
Copy link
Contributor

@alamb @liukun4515

I am submitting a bunch of the PRs now branching off my existing eq_dyn_scalar branch. The PRs now currently show all the changes because we havent merged that one in to master yet. Im hoping once that is merged i can simply rebase and these will be good to go.

@matthewmturner #1074 has been merged, you can rebase other prs, but I think we should merge the prs one by one and reduce the conflict. @alamb

@matthewmturner
Copy link
Contributor Author

@alamb @liukun4515

I am submitting a bunch of the PRs now branching off my existing eq_dyn_scalar branch. The PRs now currently show all the changes because we havent merged that one in to master yet. Im hoping once that is merged i can simply rebase and these will be good to go.

@matthewmturner #1074 has been merged, you can rebase other prs, but I think we should merge the prs one by one and reduce the conflict. @alamb

Agree. I was expecting to do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment