Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support DecimalArray in sort kernel #1137

Closed
liukun4515 opened this issue Jan 6, 2022 · 2 comments · Fixed by #1172 or #1487
Closed

Support DecimalArray in sort kernel #1137

liukun4515 opened this issue Jan 6, 2022 · 2 comments · Fixed by #1172 or #1487
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@liukun4515
Copy link
Contributor

liukun4515 commented Jan 6, 2022 •
edited
Loading

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

In the apache/datafusion#1522, we need to sort results by decimal column.

The core of the sorting decimal array is based on the sort kernel.

Describe the solution you'd like

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.
@liukun4515 liukun4515 added the enhancement Any new improvement worthy of a entry in the changelog label Jan 6, 2022
@liukun4515
Copy link
Contributor Author

I will file the pull request.

@liukun4515 liukun4515 mentioned this issue Jan 14, 2022
Merged
@alamb alamb changed the title support sort for decimal data type/ decimalarray Support DecimalArray in sort kernel Jan 20, 2022
@liukun4515
Copy link
Contributor Author

liukun4515 commented Mar 26, 2022 •
edited
Loading

add compare for decimal array
#1487

@liukun4515 liukun4515 mentioned this issue Mar 26, 2022
Merged
@alamb alamb added the arrow Changes to the arrow crate label Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
2 participants
@alamb @liukun4515