Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DecimalType in sort and take kernels #1172

Merged
merged 2 commits into from
Jan 17, 2022

Conversation

liukun4515
Copy link
Contributor

Which issue does this PR close?

Closes #1137

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 14, 2022
@liukun4515
Copy link
Contributor Author

We can fill follow-up prs to optimize decimal sort.

@codecov-commenter
Copy link

Codecov Report

Merging #1172 (a94d4eb) into master (1626b80) will increase coverage by 0.04%.
The diff coverage is 99.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1172      +/-   ##
==========================================
+ Coverage   82.66%   82.71%   +0.04%     
==========================================
  Files         173      173              
  Lines       50902    51042     +140     
==========================================
+ Hits        42079    42217     +138     
- Misses       8823     8825       +2     
Impacted Files Coverage Δ
arrow/src/compute/kernels/take.rs 95.35% <97.95%> (+0.18%) ⬆️
arrow/src/compute/kernels/sort.rs 95.13% <100.00%> (+0.31%) ⬆️
parquet_derive/src/parquet_field.rs 65.98% <0.00%> (-0.46%) ⬇️
arrow/src/array/transform/mod.rs 85.56% <0.00%> (ø)
parquet/src/encodings/encoding.rs 93.71% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1626b80...a94d4eb. Read the comment docs.

@liukun4515
Copy link
Contributor Author

@alamb @houqp PTAL

@alamb alamb changed the title support sort decimal data Support DecimalType in sort and take kernels Jan 17, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liukun4515 looks good to me

IndexType: ArrowNumericType,
IndexType::Native: ToPrimitive,
{
// TODO optimize decimal take and construct decimal array from MutableBuffer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a great follow on task / PR for someone -- I'll file a ticket

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support DecimalArray in sort kernel
3 participants