-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support DecimalType in sort
and take
kernels
#1172
Conversation
We can fill follow-up prs to optimize decimal sort. |
Codecov Report
@@ Coverage Diff @@
## master #1172 +/- ##
==========================================
+ Coverage 82.66% 82.71% +0.04%
==========================================
Files 173 173
Lines 50902 51042 +140
==========================================
+ Hits 42079 42217 +138
- Misses 8823 8825 +2
Continue to review full report at Codecov.
|
sort
and take
kernels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @liukun4515 looks good to me
IndexType: ArrowNumericType, | ||
IndexType::Native: ToPrimitive, | ||
{ | ||
// TODO optimize decimal take and construct decimal array from MutableBuffer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a great follow on task / PR for someone -- I'll file a ticket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Which issue does this PR close?
Closes #1137
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?