Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend CSV schema inference to allow scientific notation for floating point types #1215

Closed
pjmore opened this issue Jan 21, 2022 · 0 comments · Fixed by #1216
Closed

Extend CSV schema inference to allow scientific notation for floating point types #1215

pjmore opened this issue Jan 21, 2022 · 0 comments · Fixed by #1216
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@pjmore
Copy link
Contributor

pjmore commented Jan 21, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and why for this feature, in addition to the what)
@matthewmturner is working on adding datafusion to the h2oai database benchmarks. Some of the csv data uses scientific notation which the current schema inference does not support. apache/datafusion#1488

Describe the solution you'd like
A clear and concise description of what you want to happen.
Extend floating point schema inference to recognize numbers in valid scientific notation. This only requires updating the DECIMAL_RE regex that is used during schema inference as lexical_core already supports parsing numbers in this form.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Implementing alternative csv schema inference in datafusion.

@pjmore pjmore added the enhancement Any new improvement worthy of a entry in the changelog label Jan 21, 2022
@alamb alamb changed the title Extend schema inference to allow scientific notation for floating point types Extend CSV schema inference to allow scientific notation for floating point types Feb 3, 2022
@alamb alamb added the arrow Changes to the arrow crate label Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants