Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Bitmap::len to Bitmap::bit_len #1233

Closed
tustvold opened this issue Jan 23, 2022 · 1 comment · Fixed by #1242
Closed

Rename Bitmap::len to Bitmap::bit_len #1233

tustvold opened this issue Jan 23, 2022 · 1 comment · Fixed by #1242
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

#1231 was caused by a somewhat confusingly named method on Bitmap

Describe the solution you'd like

Rename the method to avoid future confusion

Describe alternatives you've considered

Document the method extensively
@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Jan 23, 2022
@tustvold tustvold mentioned this issue Jan 24, 2022
Merged
@alamb alamb mentioned this issue Jan 24, 2022
Merged
@HaoYang670
Copy link
Contributor

Do we still need to rename it, as the documentation has been improved? If so, I would like to solve this issue.

@HaoYang670 HaoYang670 mentioned this issue Jan 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename the function Bitmap::len to Bitmap::bit_len to clarify its meaning HaoYang670/arrow-rs
2 participants
@tustvold @HaoYang670