Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the function Bitmap::len to Bitmap::bit_len to clarify its meaning #1242

Merged
merged 1 commit into from Jan 28, 2022

Conversation

HaoYang670
Copy link
Contributor

Signed-off-by: remzi 13716567376yh@gmail.com

Which issue does this PR close?

Closes #1233 .

Rationale for this change

The name bit_len is more clear because the function return the length of bits (not bytes).

What changes are included in this PR?

Are there any user-facing changes?

The function name is changed.

Signed-off-by: remzi <13716567376yh@gmail.com>
@github-actions github-actions bot added arrow Changes to the arrow crate parquet Changes to the parquet crate labels Jan 27, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1242 (cbdf4c3) into master (731e132) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1242      +/-   ##
==========================================
- Coverage   82.96%   82.95%   -0.01%     
==========================================
  Files         178      178              
  Lines       51522    51522              
==========================================
- Hits        42743    42742       -1     
- Misses       8779     8780       +1     
Impacted Files Coverage Δ
arrow/src/bitmap.rs 88.13% <100.00%> (ø)
...rquet/src/arrow/record_reader/definition_levels.rs 86.25% <100.00%> (ø)
arrow/src/array/transform/mod.rs 84.64% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 731e132...cbdf4c3. Read the comment docs.

@alamb alamb added the api-change Changes to the arrow API label Jan 27, 2022
@alamb
Copy link
Contributor

alamb commented Jan 27, 2022

Thanks @HaoYang670

@alamb alamb merged commit aa71aea into apache:master Jan 28, 2022
@alamb alamb changed the title Rename the function len to bit_len for Bitmap Rename the function Bitmap::len to Bitmap::bit_len to clarify its meaning Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change Changes to the arrow API arrow Changes to the arrow crate parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Bitmap::len to Bitmap::bit_len
3 participants