Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Use Arrow take kernel Within parquet ListArrayReader #1482

Closed
tustvold opened this issue Mar 24, 2022 · 2 comments · Fixed by #1490
Closed

Cleanup: Use Arrow take kernel Within parquet ListArrayReader #1482

tustvold opened this issue Mar 24, 2022 · 2 comments · Fixed by #1490
Labels
parquet Changes to the parquet crate

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

The ListArrayReader currently uses a custom remove_indices function in order to strip nulls from its values array.

Describe the solution you'd like

This function is very similar to the arrow take kernel, and with some minor tweaks we can likely eliminate a non-trivial amount of code from the parquet crate, whilst also potentially improving performance

Describe alternatives you've considered

The code could remain unchanged

Additional context

Originally pointed out here

@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Mar 24, 2022
@viirya
Copy link
Member

viirya commented Mar 26, 2022

@tustvold Do you plan to do this? If not, I might take some time in the weekend to play with this.

@tustvold
Copy link
Contributor Author

tustvold commented Mar 26, 2022

I have no imminent plans to do this, so it would be great if you could 👍

@alamb alamb added arrow Changes to the arrow crate parquet Changes to the parquet crate and removed enhancement Any new improvement worthy of a entry in the changelog arrow Changes to the arrow crate labels Mar 31, 2022
@alamb alamb changed the title Use Arrow take kernel Within ListArrayReader Cleanup: Use Arrow take kernel Within parquet ListArrayReader Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants