Use Arrow take kernel within ListArrayReader #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1490 +/- ##
==========================================
+ Coverage 82.72% 82.76% +0.03%
==========================================
Files 188 188
Lines 54286 54241 -45
==========================================
- Hits 44908 44891 -17
+ Misses 9378 9350 -28
Continue to review full report at Codecov.
|
viirya
changed the title
viirya
changed the title
tustvold
approved these changes
Mar 28, 2022
parquet/src/arrow/array_reader.rs
Outdated
| let batch_values = match non_null_list_indices.len() { | ||
| l if l == def_levels.len() => next_batch_array.clone(), | ||
| _ => { | ||
| let indices = UInt32Array::from(non_null_list_indices); |
There was a problem hiding this comment.
You could remove the collect and then use from_iter_values, aside from being faster, this would also avoid unnecessary work in the no-nulls case.
parquet/src/arrow/array_reader.rs
Outdated
| None | ||
| } else { | ||
| Some(index as u32) |
There was a problem hiding this comment.
This could be more concisely written as (*def > self.list_empty_def_level).then(|| index as u32)
|
Thank you @tustvold 😄 |
|
Thank you @alamb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1482.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?