Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ComplexObjectArrayReader #1661

Closed
tustvold opened this issue May 6, 2022 · 0 comments · Fixed by #2528
Closed

Remove ComplexObjectArrayReader #1661

tustvold opened this issue May 6, 2022 · 0 comments · Fixed by #2528
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@tustvold
Copy link
Contributor

tustvold commented May 6, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

The ComplexObjectArrayReader logic has mostly been replaced by the likes of #1040 #1082 #1180, and is now only used for

  • Tests
  • Int96, Decimal, Interval, FixedLenByteArray

Describe the solution you'd like

It would be nice to move this logic into one or two dedicated ArrayReader implementations, this will not only significantly improve performance for these types, but also allow removing code.

Describe alternatives you've considered

We could not do this

Additional context

The module is marked experimental and so this would not constitute a breaking change
@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label May 6, 2022
tustvold added a commit to tustvold/arrow-rs that referenced this issue May 6, 2022
@tustvold
Remove parquet dictionary converters (apache#1661)
94d6ca4
alamb pushed a commit that referenced this issue May 6, 2022
@tustvold
Remove parquet dictionary converters (#1661) (#1662)
1201cb5
@tustvold tustvold mentioned this issue Jun 9, 2022
Merged
This was referenced Aug 1, 2022
Closed
Closed
@tustvold tustvold mentioned this issue Aug 8, 2022
Merged
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 9, 2022
@tustvold
Decouple parquet fuzz tests from converter (apache#1661)
1bce846
@tustvold tustvold mentioned this issue Aug 9, 2022
Merged
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 9, 2022
@tustvold
Decouple parquet fuzz tests from converter (apache#1661)
db944fb
tustvold added a commit that referenced this issue Aug 11, 2022
@tustvold
Decouple parquet fuzz tests from converter (#1661) (#2386)
5127490
This was referenced Aug 16, 2022
Merged
Closed
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add FixedLengthByteArrayReader Remove ComplexObjectArrayReader tustvold/arrow-rs
1 participant
@tustvold