Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DecimalArray to a new file #1985

Closed
HaoYang670 opened this issue Jul 1, 2022 · 0 comments · Fixed by #1986
Closed

Move DecimalArray to a new file #1985

HaoYang670 opened this issue Jul 1, 2022 · 0 comments · Fixed by #1986
Labels
arrow Changes to the arrow crate

Comments

@HaoYang670
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
The DecimalArray is currently defined in array_binary.rs, which doesn't make sense to me.
Based on the definition : https://github.com/apache/arrow/blob/master/format/Schema.fbs#L181-L195
Decimal Array is a logical type whose physical layout is more like a primitive array.

This is the reason of moving Decimal Array out array_binary.rs.

Describe the solution you'd like
Create a new file array_decimal.rs and move the decimal array here.

Describe alternatives you've considered
We could not do this.

Additional context
Add any other context or screenshots about the feature request here.

@HaoYang670 HaoYang670 added the enhancement Any new improvement worthy of a entry in the changelog label Jul 1, 2022
@alamb alamb changed the title Move the DecimalArray to a new file. Move DecimalArray to a new file Jul 7, 2022
@alamb alamb added arrow Changes to the arrow crate and removed enhancement Any new improvement worthy of a entry in the changelog labels Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants