Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move with_precision_and_scale to Decimal array traits #2291

Closed
viirya opened this issue Aug 3, 2022 · 0 comments · Fixed by #2292
Closed

Move with_precision_and_scale to Decimal array traits #2291

viirya opened this issue Aug 3, 2022 · 0 comments · Fixed by #2292
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@viirya
Copy link
Member

viirya commented Aug 3, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

with_precision_and_scale is now only for Decimal128Array. It looks like a common function for both Decimal128Array and Decimal256Array and should be defined in the trait.

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@viirya viirya added the enhancement Any new improvement worthy of a entry in the changelog label Aug 3, 2022
@viirya viirya changed the title Move with_precision_and_scale to trait Move with_precision_and_scale to Decimal array trait Aug 3, 2022
@viirya viirya mentioned this issue Aug 3, 2022
Merged
@alamb alamb changed the title Move with_precision_and_scale to Decimal array trait Move with_precision_and_scale to Decimal array traits Aug 4, 2022
@alamb alamb added the arrow Changes to the arrow crate label Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move with_precision_and_scale to BasicDecimalArray trait viirya/arrow-rs
2 participants
@viirya @alamb