Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The function new_buffers should return Vec<Buffer> #3586

Closed
askoa opened this issue Jan 23, 2023 · 3 comments
Closed

The function new_buffers should return Vec<Buffer> #3586

askoa opened this issue Jan 23, 2023 · 3 comments
Assignees
@tustvold
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@askoa
Copy link
Contributor

askoa commented Jan 23, 2023

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

from @tustvold #3553 (comment)

We should probably clean up this method to return Vec to be consistent with what ArrayData expects

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@askoa askoa added the enhancement Any new improvement worthy of a entry in the changelog label Jan 23, 2023
@askoa askoa changed the title The function new_buffers should Vec<Buffer> The function new_buffers should return Vec<Buffer> Jan 23, 2023
@askoa askoa mentioned this issue Jan 23, 2023
Merged
@tustvold tustvold self-assigned this Feb 6, 2023
@tustvold
Copy link
Contributor

tustvold commented Feb 6, 2023

I plan to pick this one up

@Weijun-H
Copy link
Member

I plan to pick this one up

Could I try to complete this task?

@tustvold
Copy link
Contributor

This will get modified as part of #1176 so I would hold off 😅

@tustvold tustvold removed good first issue Good for newcomers help wanted labels Feb 25, 2023
@tustvold tustvold closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tustvold tustvold

Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tustvold @Weijun-H @askoa