Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Human Readable Duration Display #4554

Closed
tustvold opened this issue Jul 21, 2023 · 1 comment · Fixed by #4581
Closed

Human Readable Duration Display #4554

tustvold opened this issue Jul 21, 2023 · 1 comment · Fixed by #4581
Assignees
@tustvold
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Currently durations are printed using the default Display for chrono::Duration which ISO 8601. However, this format is:

  • Not very readable
  • Is misleading as it displays days, despite the fact these will not be handled as calendar days for arithmetic (like intervals)

Describe the solution you'd like

We should display the values faithfully, e.g. as 139493 milliseconds for DurationMillisecondArray

Describe alternatives you've considered

Additional context
@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Jul 21, 2023
@tustvold tustvold self-assigned this Jul 21, 2023
@tustvold tustvold mentioned this issue Jul 21, 2023
Closed
tustvold added a commit to tustvold/arrow-rs that referenced this issue Jul 21, 2023
@tustvold
Change Duration Display (apache#4554)
e0bb1bf
tustvold added a commit to tustvold/arrow-rs that referenced this issue Jul 29, 2023
@tustvold
Add non-ISO duration display (apache#4554)
2790d0b
@tustvold tustvold changed the title Format Durations As Integer Number of Time Unit Human Readable Duration Display Jul 29, 2023
@tustvold tustvold mentioned this issue Jul 29, 2023
Merged
tustvold added a commit that referenced this issue Jul 30, 2023
@tustvold
Configurable Duration Display (#4581)
fb926a4 
* Make FormatOptions const (#4580)

* Add non-ISO duration display (#4554)

* Review feedback
@tustvold tustvold added the arrow Changes to the arrow crate label Jul 30, 2023
@tustvold
Copy link
Contributor Author

label_issue.py automatically added labels {'arrow'} from #4581

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tustvold tustvold

Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
1 participant
@tustvold