Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FlightSQL] SubstraitPlan structure is not exported #4932

Closed
amartins23 opened this issue Oct 13, 2023 · 4 comments · Fixed by #4933
Closed

[FlightSQL] SubstraitPlan structure is not exported #4932

amartins23 opened this issue Oct 13, 2023 · 4 comments · Fixed by #4933
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate bug

Comments

@amartins23
Copy link
Contributor

Describe the bug
The arrow_flight crate defines commands that use substraitplans, but does not export the structure that holds those plans SubstraitPlan in the arrow_flight::sql module, making it impossible to use CommandStatementSubstraitPlan and ActionCreatePreparedSubstraitPlanRequest.

To Reproduce
Try to use structure in code, or just look at the docs in crates.io.

Expected behavior
Structure should be exported.

Additional context
@amartins23 amartins23 added the bug label Oct 13, 2023
amartins23 added a commit to amartins23/arrow-rs that referenced this issue Oct 13, 2023
@amartins23
Expose SubstraitPlan structure in arrow_flight::sql (apache#4932)
2b4712a
@amartins23 amartins23 mentioned this issue Oct 13, 2023
Merged
@amartins23
Copy link
Contributor Author

It would be nice if the fix could be back ported to older arrow versions, namely 43 and 47.

alamb pushed a commit that referenced this issue Oct 17, 2023
@amartins23
Expose SubstraitPlan structure in arrow_flight::sql (#4932) (#4933)
952cd2e
@alamb
Copy link
Contributor

alamb commented Oct 17, 2023

It would be nice if the fix could be back ported to older arrow versions, namely 43 and 47.

Thanks @amartins23 -- we don't currently have the bandwidth to do releases for older versions, though we could certainly do so with some more help. Any chance you have some time to help with such a thing (basically make a branch, and then create the README, / bump versions). If so I an provide more details

@tustvold tustvold added the arrow Changes to the arrow crate label Oct 18, 2023
@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'arrow'} from #4933

@tustvold tustvold added the arrow-flight Changes to the arrow-flight crate label Oct 18, 2023
@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'arrow-flight'} from #4933

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Export SubstraitPlan structure in arrow_flight::sql (#4932) amartins23/arrow-rs
3 participants
@alamb @tustvold @amartins23