Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rand an optional dependency #671

Closed
roee88 opened this issue Aug 6, 2021 · 1 comment · Fixed by #674
Closed

Make rand an optional dependency #671

roee88 opened this issue Aug 6, 2021 · 1 comment · Fixed by #674
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@roee88
Copy link
Contributor

roee88 commented Aug 6, 2021

Following #488 arrow-rs compiles to wasm32-unknown-unknowm only with the "js" feature of rand enabled. However, when the "js" feature is enabled the produced wasm modules are no longer stand alone and require JavaScript, which is not necessarily available. For example, these modules can't run in runtimes like wasmer (in contrast to modules compiled to wasm32-unknown-unknowm with arrow-rs 4.x).

Describe the solution you'd like

Make rand an optional dependency so we can opt out. In arrow2 this is already the case (and at least there rand is only used in benchmarks).

Describe alternatives you've considered

If it's only use for benchmarks and testing in arrow-rs too then make it an optional dependency that is only enabled when feature flags for benchmarks are set (if that exists already).

@roee88 roee88 added the enhancement Any new improvement worthy of a entry in the changelog label Aug 6, 2021
@alamb
Copy link
Contributor

alamb commented Aug 7, 2021

sounds like a good idea to me -- @roee88 do you plan to work on this one or would you like help?

roee88 added a commit to roee88/arrow-rs that referenced this issue Aug 8, 2021
Closes apache#671

Signed-off-by: roee88 <roee88@gmail.com>
roee88 added a commit to roee88/arrow-rs that referenced this issue Aug 8, 2021
Closes apache#671

Signed-off-by: roee88 <roee88@gmail.com>
@alamb alamb closed this as completed in #674 Aug 9, 2021
alamb pushed a commit that referenced this issue Aug 9, 2021
Closes #671

Signed-off-by: roee88 <roee88@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants