Cherry pick Fix warnings introduced by Rust/Clippy 1.57.0 to active_release #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove needless borrows identified by clippy https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow * Remove muts that are no longer needed * Derive Default instead of using an equivalent manual impl Identified by clippy. https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls * Remove redundant closures Identified by clippy. https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure * Allow dead code on a field Rust now identifies as never read
github-actions
bot
added
arrow
Codecov Report
@@ Coverage Diff @@
## active_release #1004 +/- ##
==================================================
- Coverage 82.35% 82.34% -0.02%
==================================================
Files 168 168
Lines 48834 48832 -2
==================================================
- Hits 40219 40211 -8
- Misses 8615 8621 +6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic cherry-pick of 9fb2a5f