Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick Extract method to drive PageIterator -> RecordReader to active_release #1056

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Dec 17, 2021

Automatic cherry-pick of ab48e69

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@github-actions github-actions bot added the parquet Changes to the parquet crate label Dec 17, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1056 (6cd101c) into active_release (7a0bca3) will decrease coverage by 0.00%.
The diff coverage is 93.75%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           active_release    #1056      +/-   ##
==================================================
- Coverage           82.38%   82.37%   -0.01%     
==================================================
  Files                 168      168              
  Lines               49133    49124       -9     
==================================================
- Hits                40476    40464      -12     
- Misses               8657     8660       +3     
Impacted Files Coverage Δ
parquet/src/arrow/array_reader.rs 76.75% <93.75%> (-0.10%) ⬇️
parquet/src/schema/printer.rs 72.47% <0.00%> (-0.55%) ⬇️
parquet/src/encodings/encoding.rs 93.52% <0.00%> (-0.20%) ⬇️
parquet/src/arrow/arrow_array_reader.rs 77.87% <0.00%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a0bca3...6cd101c. Read the comment docs.

@alamb alamb merged commit 1c59023 into active_release Dec 20, 2021
@alamb alamb deleted the cherry_pick_ab48e690 branch December 20, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants