Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick Use existing array type in take kernel to active_release #1057

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Dec 17, 2021

Automatic cherry-pick of 2d28534

* Need to use type from data so that we do not lose, for example, timezone information

* add test for take preseving timezone
@github-actions github-actions bot added the arrow Changes to the arrow crate label Dec 17, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2021

Codecov Report

Merging #1057 (f9489c2) into active_release (7a0bca3) will decrease coverage by 0.00%.
The diff coverage is 90.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           active_release    #1057      +/-   ##
==================================================
- Coverage           82.38%   82.37%   -0.01%     
==================================================
  Files                 168      168              
  Lines               49133    49143      +10     
==================================================
+ Hits                40476    40481       +5     
- Misses               8657     8662       +5     
Impacted Files Coverage Δ
arrow/src/compute/kernels/take.rs 95.14% <90.00%> (-0.08%) ⬇️
parquet/src/schema/printer.rs 72.47% <0.00%> (-0.55%) ⬇️
parquet/src/arrow/arrow_array_reader.rs 77.87% <0.00%> (-0.15%) ⬇️
arrow/src/array/transform/mod.rs 85.20% <0.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a0bca3...f9489c2. Read the comment docs.

@alamb alamb merged commit 71ac862 into active_release Dec 20, 2021
@alamb alamb deleted the cherry_pick_2d28534b branch December 20, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants