Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick support cast signed numeric to decimal to active_release #1079

Merged
merged 1 commit into from Dec 22, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Dec 21, 2021

Automatic cherry-pick of 4b3d928

* support cast signed numeric to decimal

* add test for i8,i16,i32,i64,f32,f64 casted to decimal

* change format of float64

* add none test; merge integer test together
@github-actions github-actions bot added the arrow Changes to the arrow crate label Dec 21, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1079 (36e87a3) into active_release (31911a4) will increase coverage by 0.02%.
The diff coverage is 97.53%.

❗ Current head 36e87a3 differs from pull request most recent head 2dcdf76. Consider uploading reports for the commit 2dcdf76 to get more accurate results
Impacted file tree graph

@@                Coverage Diff                 @@
##           active_release    #1079      +/-   ##
==================================================
+ Coverage           82.37%   82.39%   +0.02%     
==================================================
  Files                 168      168              
  Lines               49134    49213      +79     
==================================================
+ Hits                40474    40549      +75     
- Misses               8660     8664       +4     
Impacted Files Coverage Δ
arrow/src/compute/kernels/cast.rs 94.65% <97.53%> (+0.17%) ⬆️
parquet_derive/src/parquet_field.rs 65.75% <0.00%> (-0.46%) ⬇️
arrow/src/datatypes/field.rs 53.37% <0.00%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31911a4...2dcdf76. Read the comment docs.

@alamb alamb merged commit 3a5e354 into active_release Dec 22, 2021
@alamb alamb deleted the cherry_pick_4b3d9283 branch December 22, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants