Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print the 'FixedSizeBinaryArray' like a normal 'BinaryArray' #1097

Merged

Conversation

GrandChaman
Copy link
Contributor

Which issue does this PR close?

Closes #1096.

Rationale for this change

See #1096.

What changes are included in this PR?

A new match arm has been added to the array_value_to_string function to allow pretty printing FixedSizeBinaryArray.

Are there any user-facing changes?

Not directly.

@github-actions github-actions bot added the arrow Changes to the arrow crate label Dec 27, 2021
Copy link
Contributor

@liukun4515 liukun4515 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @GrandChaman -- also for the test ❤️

@alamb
Copy link
Contributor

alamb commented Dec 28, 2021

The tests are failing due to an unrelated reason -- see #1102 -- will resolve them and get back to this

@alamb
Copy link
Contributor

alamb commented Dec 29, 2021

FYI @GrandChaman I have merged master to this branch, and hopefully we'll get a clean CI run now

@alamb
Copy link
Contributor

alamb commented Dec 29, 2021

I also pushed a fix for rust fmt: 39e8326

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2021

Codecov Report

Merging #1097 (39e8326) into master (3dca969) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1097   +/-   ##
=======================================
  Coverage   82.31%   82.31%           
=======================================
  Files         168      168           
  Lines       49420    49421    +1     
=======================================
+ Hits        40681    40683    +2     
+ Misses       8739     8738    -1     
Impacted Files Coverage Δ
arrow/src/util/display.rs 19.62% <0.00%> (-0.19%) ⬇️
arrow/src/datatypes/datatype.rs 66.38% <0.00%> (-0.43%) ⬇️
arrow/src/array/transform/mod.rs 84.86% <0.00%> (ø)
parquet_derive/src/parquet_field.rs 66.43% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dca969...39e8326. Read the comment docs.

@alamb alamb merged commit 74591a5 into apache:master Dec 29, 2021
@alamb
Copy link
Contributor

alamb commented Dec 29, 2021

Thanks again @GrandChaman

@GrandChaman GrandChaman deleted the fixedlen_binary_array_pretty_printing branch December 30, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pretty printing FixedSizeBinaryArray
4 participants