Add support for MapArray in json writer
#1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jan 11, 2022
|
|
||
| // Keys have to be strings to convert to json. | ||
| if !matches!(keys.data_type(), DataType::Utf8) { | ||
| panic!("Unsupported datatype: {:#?}", array.data_type()); |
There was a problem hiding this comment.
it would be much nicer if this code did not panic when there was an unsupported datatype. However, I see that the the signature for set_column_for_json_rows does not return a Result 😢
I'll file a follow on ticket and see if someone in the community is interesting in improving this
| false, | ||
| ); | ||
|
|
||
| // [{"foo": 10}, null, {}, {"bar": 20, "baz": 30, "qux": 40}, {"quux": 50}, {}] |
There was a problem hiding this comment.
It would be great to have a better / nicer way to contruct MapArrays -- again not for this PR but eventually it would be nice to have something like
https://docs.rs/arrow/6.5.0/arrow/array/struct.StructArray.html
I will file another ticket
This was referenced Jan 11, 2022
|
Thanks again @helgikrs |
alamb
added
the
enhancement
alamb
changed the title
alamb
changed the title
MapArray in json writer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR adds map arrays into the json writer, tracked by #538.
What changes are included in this PR?
This PR adds support for writing map arrays to json and a new test for this functionality in the json writer.
Are there any user-facing changes?
Adds a new public function,
as_map_array, toarrow::array::cast.